Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identity provider section. #1619

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Conversation

rkratky
Copy link

@rkratky rkratky commented Oct 4, 2020

What does this PR do?

  • Uses attributes consistently for identity provider.
  • Fixes some language and formatting.

Specify the version of the product this PR applies to.

7.18+

PR Checklist

As the author of this Pull Request I made sure that:

  • [ x ] vale has been run successfully against the PR branch
  • [ x ] Link checker has been run successfully against the PR branch
  • [ x ] Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • [ x ] Changed article references are updated where they are used (or a redirect has been set up on the docs side):

@@ -43,7 +43,6 @@ asciidoc:
identity-provider-url: https://www.keycloak.org/
identity-provider-version: "6.0"
identity-provider: Keycloak
identity-provider2: Keycloak
Copy link

@yhontyk yhontyk Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this get reflected in the downstream? Those are two distinct attributes there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an MR for downstream that fixes it.

@rkratky rkratky merged commit 218f5c2 into eclipse-che:master Oct 19, 2020
@rkratky rkratky deleted the fix-ext-keycloak branch October 19, 2020 08:13
@rkratky rkratky added cherry-picked to 7.30.x need-cherry-pick/7.32.x need cherry-pick to 7.32.x cherry-picked to 7.32.x cherry-picked to 7.32.x and removed need-cherry-pick/7.34.x need cherry-pick to 7.18.x branch need-cherry-pick/7.32.x need cherry-pick to 7.32.x labels Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants