Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove conditionals. #1751

Merged
merged 4 commits into from Dec 18, 2020
Merged

Remove conditionals. #1751

merged 4 commits into from Dec 18, 2020

Conversation

yhontyk
Copy link

@yhontyk yhontyk commented Dec 17, 2020

Read our Contribution guide before submitting a PR.

What does this PR do?

Removes unnecessary conditionals and introduces a few attributized URLs.

Specify the version of the product this PR applies to.

Current

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been set up on the docs side):

@yhontyk yhontyk added the need-cherry-pick/7.32.x need cherry-pick to 7.32.x label Dec 17, 2020
@yhontyk yhontyk requested a review from themr0c December 17, 2020 14:53
@yhontyk yhontyk requested review from MichalMaler, rkratky and a team as code owners December 17, 2020 14:53
@yhontyk yhontyk requested review from ibuziuk and removed request for a team December 17, 2020 14:53
themr0c
themr0c reviewed Dec 18, 2020
View reviewed changes
antora-playbook.yml Outdated Show resolved Hide resolved
themr0c
themr0c reviewed Dec 18, 2020
View reviewed changes
antora-playbook.yml Outdated Show resolved Hide resolved
@themr0c
Copy link
Contributor

themr0c commented Dec 18, 2020

I believe this PR is pure docs internal kitchen, removing the necessity of a second read.

@themr0c themr0c removed the request for review from ibuziuk December 18, 2020 11:43
@themr0c
Update modules/administration-guide/partials/proc_using-protocol-base…
246cf72 
…d-providers.adoc


Remove fluff. Fox vale errors.
@themr0c themr0c merged commit 22ef466 into eclipse-che:master Dec 18, 2020
@yhontyk yhontyk deleted the removeUnnessesaryConditionals branch December 18, 2020 11:46
yhontyk pushed a commit that referenced this pull request Dec 23, 2020
@themr0c
Remove conditionals. (#1751)
21d06d7 
* Remove conditionals.

* Update antora-playbook.yml

* Update modules/administration-guide/partials/proc_using-protocol-based-providers.adoc

* Remove fluff. Fox vale errors.

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@yhontyk yhontyk added cherry-picked to 7.32.x cherry-picked to 7.32.x and removed need-cherry-pick/7.32.x need cherry-pick to 7.32.x labels Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themr0c themr0c themr0c approved these changes

@MichalMaler MichalMaler Awaiting requested review from MichalMaler

@rkratky rkratky Awaiting requested review from rkratky

Assignees
No one assigned
Labels
cherry-picked to 7.32.x cherry-picked to 7.32.x
Projects
None yet
Milestone
No milestone
3 participants
@yhontyk @themr0c @che-bot