Clarify devfile storage locations #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of RHDEVDOCS-2300 Signed-off-by: Eric Williams <ericwill@redhat.com>
ericwill
requested review from
yhontyk,
MichalMaler,
rkratky,
themr0c and
a team
as code owners
|
Is it expected that vale will check all errors in a file? I see several errors for lines I didn't touch. Should I fix them all in this PR? |
MichalMaler
approved these changes
Jan 8, 2021
MichalMaler
added
kind/enhancement
need-cherry-pick/7.32.x
Signed-off-by: Michal Maléř <mmaler@redhat.com>
|
GJ Eric! Thx a lot. |
MichalMaler
added a commit
that referenced
this pull request
Jan 8, 2021
* Clarify devfile storage/deployment schemes Part of RHDEVDOCS-2300 Signed-off-by: Eric Williams <ericwill@redhat.com> * Review+vale fixes Signed-off-by: Michal Maléř <mmaler@redhat.com> Co-authored-by: Michal Maléř <mmaler@redhat.com>
MichalMaler
added
cherry-picked to 7.32.x
sleshchenko
pushed a commit
to sleshchenko/che-docs
that referenced
this pull request
Jan 22, 2021
* Clarify devfile storage/deployment schemes Part of RHDEVDOCS-2300 Signed-off-by: Eric Williams <ericwill@redhat.com> * Review+vale fixes Signed-off-by: Michal Maléř <mmaler@redhat.com> Co-authored-by: Michal Maléř <mmaler@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Williams ericwill@redhat.com
What does this PR do?
Clarifies some sections of the
What is a devfiledocumentation, to make it better understood where devfiles can be stored/deployed from.What issues does this PR fix or reference?
https://issues.redhat.com/browse/RHDEVDOCS-2300
Specify the version of the product this PR applies to.
7.x
PR Checklist
As the author of this Pull Request I made sure that:
valehas been run successfully against the PR branch