Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo fix #2038

Closed
wants to merge 3 commits into from
Closed

fix: typo fix #2038

wants to merge 3 commits into from

Conversation

MichalMaler
Copy link
Contributor

@MichalMaler MichalMaler commented Jun 23, 2021 •
edited

Signed-off-by: Michal Maléř mmaler@redhat.com

Read our Contribution guide before submitting a PR.

What does this PR do?

Fixing a typo in https://www.eclipse.org/che/docs/che-7/administration-guide/defining-the-list-of-images-to-pull/

What issues does this PR fix or reference?

eclipse-che/che#20021

Specify the version of the product this PR applies to.

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been configured on the docs side):

@MichalMaler
typo fix
f795713 
Signed-off-by: Michal Maléř <mmaler@redhat.com>
@MichalMaler MichalMaler requested review from rkratky, themr0c and a team as code owners June 23, 2021 10:57
@MichalMaler MichalMaler requested a review from benoitf June 23, 2021 10:57
@MichalMaler MichalMaler self-assigned this Jun 23, 2021
@MichalMaler MichalMaler added kind/bug kind/enhancement need-cherry-pick/7.30.x Changes that need to be incorporated into 7.14.x branch labels Jun 23, 2021
@MichalMaler MichalMaler added this to In progress in Reviews via automation Jun 23, 2021
@MichalMaler MichalMaler added this to the 7.30.x milestone Jun 23, 2021
@MichalMaler MichalMaler mentioned this pull request Jun 23, 2021
Closed
20 tasks
@MichalMaler MichalMaler changed the title typo fix fix: typo fix Jun 23, 2021
nickboldt
nickboldt approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fix good for 2.8 andearlier, but this whole section should be removed from CRW 2.9+ docs as it's not needed.

Reviews automation moved this from In progress to Reviewer approved Jun 23, 2021
@themr0c
Copy link
Contributor

themr0c commented Jun 25, 2021

#2039 is removing the file, it makes this PR obsolete.

@themr0c themr0c closed this Jun 25, 2021
Reviews automation moved this from Reviewer approved to Done Jun 25, 2021
@MichalMaler MichalMaler deleted the che-typo-fix-ImmagePullerSection branch June 25, 2021 07:35
@themr0c themr0c removed need-cherry-pick/7.30.x Changes that need to be incorporated into 7.14.x branch status/code-review labels Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt approved these changes

@themr0c themr0c themr0c approved these changes

@rkratky rkratky Awaiting requested review from rkratky

@benoitf benoitf Awaiting requested review from benoitf

Assignees

@MichalMaler MichalMaler

Labels
kind/bug kind/enhancement
Projects
Reviews
  
Done
Milestone
7.30.x
4 participants
@MichalMaler @themr0c @nickboldt @che-bot