fix: Improve language and structure of Switching between external and internal communication #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Try the PR on Eclipse Che hosted by Red Hat |
tstastna
force-pushed
the
i3230-internal-service-names-with-network-plug-in
branch
from
3b1312e
to
4d48e31
Compare
themr0c
reviewed
Sep 14, 2021
...s/installation-guide/partials/assembly_configuring-communication-between-che-components.adoc
Outdated
Show resolved
Hide resolved
themr0c
reviewed
Sep 14, 2021
...uide/partials/proc_using-the-operator-to-configure-communication-between-che-components.adoc
Outdated
Show resolved
Hide resolved
|
Click here to review and test in web IDE: |
1 similar comment
|
Click here to review and test in web IDE: |
tstastna
force-pushed
the
i3230-internal-service-names-with-network-plug-in
branch
from
66e8e32
to
6adc799
Compare
|
Click here to review and test in web IDE: |
themr0c
reviewed
Sep 16, 2021
...uide/partials/proc_using-the-operator-to-configure-communication-between-che-components.adoc
Outdated
Show resolved
Hide resolved
|
Click here to review and test in web IDE: |
tstastna
force-pushed
the
i3230-internal-service-names-with-network-plug-in
branch
from
f6499f7
to
f1ce8eb
Compare
|
Click here to review and test in web IDE: |
themr0c
reviewed
Sep 23, 2021
modules/installation-guide/pages/configuring-communication-between-che-components.adoc
Outdated
Show resolved
Hide resolved
|
Click here to review and test in web IDE: |
tstastna
force-pushed
the
i3230-internal-service-names-with-network-plug-in
branch
from
e8be66c
to
9812779
Compare
|
Click here to review and test in web IDE: |
rolfedh
reviewed
Sep 29, 2021
modules/installation-guide/partials/proc_configuring-communication-between-che-components.adoc
Outdated
Show resolved
Hide resolved
rolfedh
reviewed
Sep 29, 2021
modules/installation-guide/partials/proc_configuring-communication-between-che-components.adoc
Outdated
Show resolved
Hide resolved
rolfedh
reviewed
Sep 29, 2021
modules/installation-guide/partials/proc_configuring-communication-between-che-components.adoc
Show resolved
Hide resolved
rolfedh
reviewed
Sep 29, 2021
modules/installation-guide/partials/proc_configuring-communication-between-che-components.adoc
Show resolved
Hide resolved
rolfedh
reviewed
Sep 29, 2021
modules/installation-guide/partials/proc_configuring-communication-between-che-components.adoc
Outdated
Show resolved
Hide resolved
rolfedh
reviewed
Sep 29, 2021
modules/installation-guide/partials/proc_configuring-communication-between-che-components.adoc
Outdated
Show resolved
Hide resolved
rolfedh
reviewed
Sep 29, 2021
modules/installation-guide/partials/proc_configuring-communication-between-che-components.adoc
Outdated
Show resolved
Hide resolved
rolfedh
reviewed
Sep 29, 2021
modules/installation-guide/partials/proc_configuring-communication-between-che-components.adoc
Show resolved
Hide resolved
rolfedh
reviewed
Sep 29, 2021
modules/installation-guide/partials/proc_configuring-communication-between-che-components.adoc
Outdated
Show resolved
Hide resolved
themr0c
reviewed
Oct 20, 2021
modules/installation-guide/partials/proc_configuring-communication-between-che-components.adoc
Show resolved
Hide resolved
themr0c
reviewed
Oct 20, 2021
modules/installation-guide/partials/proc_configuring-communication-between-che-components.adoc
Outdated
Show resolved
Hide resolved
|
Click here to review and test in web IDE: |
1 similar comment
|
Click here to review and test in web IDE: |
tstastna
force-pushed
the
i3230-internal-service-names-with-network-plug-in
branch
from
22defff
to
c1fc3b9
Compare
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
MichalMaler
pushed a commit
that referenced
this pull request
Oct 21, 2021
… internal communication (#2110) * Rewrite inter-component communication procedure * Improve formatting * Add verification steps * Add sentence to the list * Improve verification, remove helm procedure * Remove redundant assembly file * Implement suggestions from peer review * Fix vale * Add note about default behavior * Fix incorrect information * Fact corrections * Fact corrections * Small language change * Small language change
MichalMaler
added
cherry-picked to 7.36.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
It removes the Switching between external and internal communication procedure and replaces it with an assembly and two procedures.
What issues does this pull request fix or reference?
Specify the version of the product this pull request applies to
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.