fix: Mounting secrets defined in a devfile #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Click here to review and test in web IDE: |
tstastna
changed the title
tstastna
requested review from
MichalMaler,
rkratky,
themr0c and
a team
as code owners
themr0c
approved these changes
Oct 28, 2021
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
|
Hello @benoitf . Can you please take a look? |
benoitf
approved these changes
Nov 9, 2021
themr0c
added a commit
that referenced
this pull request
Nov 9, 2021
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
max-cx
pushed a commit
to max-cx/che-docs
that referenced
this pull request
Nov 18, 2021
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
Add information about not mounting secrets that are defined in a devfile.
What issues does this pull request fix or reference?
Specify the version of the product this pull request applies to
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.