New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asciidoc conversion #456
Asciidoc conversion #456
Conversation
@rkratky I can't find pom.xml in the PR - have you changed Docker image here too? https://github.com/eclipse/che-docs/blob/master/pom.xml#L68 |
@eivantsov
That I forgot. I will fix that. (What is it used for?) |
Signed-off-by: Robert Krátký <rkratky@redhat.com>
Signed-off-by: Robert Krátký <rkratky@redhat.com>
Signed-off-by: Robert Krátký <rkratky@redhat.com>
Signed-off-by: Robert Krátký <rkratky@redhat.com>
Signed-off-by: Robert Krátký <rkratky@redhat.com>
Signed-off-by: Robert Krátký <rkratky@redhat.com>
Signed-off-by: Robert Krátký <rkratky@redhat.com>
Signed-off-by: Robert Krátký <rkratky@redhat.com>
a84b07b
to
0371d66
Compare
Apologies for the repeated push -- I keep forgetting to sign off on commits. |
Well, this is a maven project, and docs are packaged as war artifact that is then packaged into Che server. |
+1 for the pom.xml |
Thanks, I updated |
@rkratky can you please resolve conflicts and merge asap? |
Signed-off-by: Robert Krátký <rkratky@redhat.com>
@eivantsov Apologies for the delay, I was on PTO. The conflicts are resolved, please merge. |
Signed-off-by: Robert Krátký <rkratky@redhat.com>
Signed-off-by: Robert Krátký <rkratky@redhat.com>
What does this PR do?
Converts the entire bulk of docs from Markdown to Asciidoc(tor). The linked issue (#425) contains detailed explanation and reasoning for the conversion.
Jekyll is still used to generate the site, and the site's design and navigation elements are unchanged. I viewed every single page on the site to check for problems. If you find any, I'll fix them.
The PR includes:
run.sh
,_config.yml
,Gemfile
)run.sh
script pulls this new image)The only (quite minor) change is the syntax highlighter used for source-code listings. I couldn't get the currently used one (Rouge) to work, so I used a different one (Coderay). Syntax is still properly highlighted, only the colors used are a tiny bit different.
What issues does this PR fix or reference?
#425 (Convert docs to AsciiDoc)