Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description how user-defined PVCs are processed on different PVC strategies #657

Merged
merged 2 commits into from Jul 23, 2019

Conversation

sleshchenko
Copy link
Member

What does this PR do?

Adds description how user-defined PVCs are processed on different PVC strategies

What issues does this PR fix or reference?

eclipse-che/che#12335

@skabashnyuk
Copy link
Contributor

@dneary @slemeur @rkratky can you take a look on this PR?

@@ -99,7 +99,7 @@ In the command above, `eclipse-che` is the Che namespace.
[id="how-the-che-server-uses-PVCs-and-PVs-for-storage"]
== How the Che server uses PVCs and PVs for storage

Che server, Keycloak and PostgreSQL pods, and workspace pods use Persistent Volume Claims (PVCs), which are bound to the physical Persistent Volumes (PVs) with https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes[ReadWriteOnce access mode]. When the deployment YAML files run, they define the Che PVCs. You can configure link:#che-workspaces-storage[workspace PVC] access mode and claim size with Che deployment environment variables.
Che server, Keycloak and PostgreSQL pods, and workspace pods use Persistent Volume Claims (PVCs), which are bound to the physical Persistent Volumes (PVs) with https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes[ReadWriteOnce access mode]. When the deployment YAML files run, they contain PVCs or define the Che Volumes. You can configure link:#che-workspaces-storage[workspace PVC] access mode and claim size with Che deployment environment variables.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"When the deployment YAML files run, they contain PVCs or define the Che Volumes."
I don't understand.

  • Can a YAML file "run"
  • they contain PVCs --> ?
  • or define Che Volumes ???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I misunderstood this sentence. Now looks I should just revert my changes here. Will do it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted changes in this line. Please resolve comment if existing line

When the deployment YAML files run, they define the Che PVCs. You can configure link:#che-workspaces-storage[workspace PVC] access mode and claim size with Che deployment environment variables.

is OK for you.

@slemeur
Copy link
Contributor

slemeur commented Jan 21, 2019

Also do you confirm it is working the same for OS?

@sleshchenko
Copy link
Member Author

Also do you confirm it is working the same for OS?

Yes, it works for both of Kubernetes and OpenShift infrastructures. The modified page is included in Che on Kubernetes: Admin Guide and Che on OpenShift: Admin Guide articles.
@slemeur I fixed your comments, Could you please review one more time?

@sleshchenko sleshchenko requested a review from slemeur April 2, 2019 12:39
@slemeur
Copy link
Contributor

slemeur commented Apr 3, 2019

@rkratky is that fine for you?

@slemeur
Copy link
Contributor

slemeur commented Jul 23, 2019

@rkratky : that PR has slipped while the content is making a great difference. I fixed the conflicts and going to merge, as there are explanation that would be much valuable for Che 7 (and CRW too).

@slemeur slemeur merged commit 2ca4401 into eclipse-che:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants