Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configMap concept module to the Che 7 docs #816

Merged

Conversation

MichalMaler
Copy link
Contributor

Waiting for the information where to put this concent in Che 6 @rkratky
Robert, your peer review would also be useful before moving this concept module into Che 6 docs (to prevent duplicated typos and so on)

eclipse-che/che#14075

https://docs.google.com/document/d/1eMRB_FDgEqzVzCBKOdhjA1eypw-Fl6bljuDrnRepBHk/edit#

Signed-off-by: Michal Maléř <mmaler@redhat.com>
Signed-off-by: Michal Maléř <mmaler@redhat.com>
Copy link
Contributor

@themr0c themr0c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All requests for changes have been applied in 93507af

@themr0c themr0c dismissed rkratky’s stale review September 18, 2019 07:20

All requests for changes have been applied in 93507af

@themr0c themr0c merged commit d4a7ad4 into eclipse-che:master Sep 18, 2019
@MichalMaler MichalMaler deleted the i1248_configMaps-and-their-behavior branch September 18, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants