-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some known issues when upgrading from Che6 using the operator. #837
Conversation
describing the Che installation. Namely, it might be necessary to review the following components: | ||
|
||
|=== | ||
| Component | CR attribute name | How to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks: the main things to do, to pull the new default docker images for Che 7, is simply to reset the CR docker images fields to an empty string, which means: use the current default.
And this should be done for :
- Keycloak: field
identityProviderImage
- Postgres: field
postgresImage
(because postgres images regularly change due to CVEs and there's not warranty that the CRW 2.0 postgres image will the be the same as the one of the last CRW 1.2.x release) - Pvc Jobs Image: field
pvcJobsImage
(same reason related the CVEs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidfestal @metlos is there an issue for that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I'm sugesting changes to the current documentation PR. Why would we need an additional issue ? I already explained as part of issue comment eclipse-che/che#14200 (comment) :
the user should have to manually clean the frozen docker image versions in the CheCluster (set them back to empty string for Keycloak, Postgres, etc ...) just after upgrading the operator to 7.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I just thought we need some additional coding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidfestal good point. I have reworded the fix suggestions and added the missing properties to the table. Do you think it is OK like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidfestal, are you OK with the reworded text @metlos provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I just approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitted my suggestions as metlos#1
Che6 upgrade notes rkratky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @metlos!
What does this PR do?
Adds notes about upgrade from Che6 using the operator to the installation guide.
What issues does this PR fix or reference?
eclipse-che/che#14738