Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Use 'containerName' instead of 'machineName' for che tasks #414

Merged
merged 1 commit into from Aug 22, 2019

Conversation

RomanNikitenko
Copy link
Member

The changes are the same as in the PR #367

What does this PR do?

Use 'containerName' instead of 'machineName' for che tasks

What issues does this PR fix or reference?

eclipse-che/che#13667

How to test

Use the component in your devfile

- 
    alias: theia-editor
    reference: >-
      https://raw.githubusercontent.com/RomanNikitenko/che-plugin-registry/master/v3/plugins/eclipse/che-theia/next/meta.yaml
    type: cheEditor

Use some command in your devfile, for example:

- name: che-theia:build
  actions:
  - type: exec
    component: che-dev
    command: >
              yarn
    workdir: /projects/che-theia

The component field defined for a command in a devfile should be converted into containerName (not machineName) field for a task configuration in a tasks.json file when a workspace has started.

containerName

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still relevant? I mean that there is another issue to use component instead. Or it will be the next step?

@vparfonov
Copy link
Contributor

Is it still relevant? I mean that there is another issue to use component instead. Or it will be the next step?

yes, it will be next step. With this PR we align with 7.0 version

@RomanNikitenko
Copy link
Member Author

RomanNikitenko commented Aug 22, 2019

@sleshchenko
You are right - we are going to use component instead of machineName, but we are not ready for it and we have the corresponding issue.
So I would like to align the behavior for master branch with 7.0.0 and we can improve it when the corresponding issue is resolved.

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko
Copy link
Member Author

I had to force-push the same changes to restart ci-build.

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for answering my question.

@RomanNikitenko RomanNikitenko merged commit cac8361 into master Aug 22, 2019
@RomanNikitenko RomanNikitenko deleted the container_name branch August 22, 2019 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants