Clean up 'YamlExtensionManagerViewImpl'

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
eclipse-che · Oct 13, 2017 · fe6d621 · fe6d621
1 parent 6019a0c
commit fe6d621
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 28 deletions.
diff --git a/...c/main/java/org/eclipse/che/plugin/yaml/ide/preferences/YamlExtensionManagerViewImpl.java b/...c/main/java/org/eclipse/che/plugin/yaml/ide/preferences/YamlExtensionManagerViewImpl.java
@@ -48,7 +48,7 @@ interface YamlExtensionManagerViewImplUiBinder
   @UiField Button addUrl;
 
   @UiField(provided = true)
-  CellTable<YamlPreference> YamlPreferenceCellTable;
+  CellTable<YamlPreference> yamlPreferenceCellTable;
 
   @UiField Label headerUiMsg;
 
@@ -58,9 +58,9 @@ interface YamlExtensionManagerViewImplUiBinder
 
   @Inject
   protected YamlExtensionManagerViewImpl(CellTableResources res, YamlLocalizationConstant local) {
+    this.local = local;
     initYamlExtensionTable(res);
     initWidget(uiBinder.createAndBindUi(this));
-    this.local = local;
   }
 
   /**
@@ -70,7 +70,7 @@ protected YamlExtensionManagerViewImpl(CellTableResources res, YamlLocalizationC
    */
   private void initYamlExtensionTable(final CellTable.Resources res) {
 
-    YamlPreferenceCellTable = new CellTable<YamlPreference>(20, res);
+    yamlPreferenceCellTable = new CellTable<YamlPreference>(20, res);
     Column<YamlPreference, String> urlColumn =
         new Column<YamlPreference, String>(new EditTextCell()) {
           @Override
@@ -157,22 +157,22 @@ public void update(int index, YamlPreference object, String value) {
           }
         });
 
-    YamlPreferenceCellTable.addColumn(urlColumn, local.urlColumnHeader());
-    YamlPreferenceCellTable.addColumn(globColumn, local.globColumnHeader());
-    YamlPreferenceCellTable.addColumn(deletePreferenceColumn, local.deleteColumnHeader());
-    YamlPreferenceCellTable.setWidth("100%", true);
-    YamlPreferenceCellTable.setColumnWidth(urlColumn, 45, Style.Unit.PCT);
-    YamlPreferenceCellTable.setColumnWidth(globColumn, 30, Style.Unit.PCT);
-    YamlPreferenceCellTable.setColumnWidth(deletePreferenceColumn, 25, Style.Unit.PCT);
+    yamlPreferenceCellTable.addColumn(urlColumn, local.urlColumnHeader());
+    yamlPreferenceCellTable.addColumn(globColumn, local.globColumnHeader());
+    yamlPreferenceCellTable.addColumn(deletePreferenceColumn, local.deleteColumnHeader());
+    yamlPreferenceCellTable.setWidth("100%", true);
+    yamlPreferenceCellTable.setColumnWidth(urlColumn, 45, Style.Unit.PCT);
+    yamlPreferenceCellTable.setColumnWidth(globColumn, 30, Style.Unit.PCT);
+    yamlPreferenceCellTable.setColumnWidth(deletePreferenceColumn, 25, Style.Unit.PCT);
 
     // don't show loading indicator
-    YamlPreferenceCellTable.setLoadingIndicator(null);
+    yamlPreferenceCellTable.setLoadingIndicator(null);
   }
 
   /** {@inheritDoc} */
   @Override
   public void setPairs(@NotNull List<YamlPreference> pairs) {
-    this.YamlPreferenceCellTable.setRowData(pairs);
+    this.yamlPreferenceCellTable.setRowData(pairs);
   }
 
   /** {@inheritDoc} */

diff --git a/...main/java/org/eclipse/che/plugin/yaml/ide/preferences/YamlExtensionManagerViewImpl.ui.xml b/...main/java/org/eclipse/che/plugin/yaml/ide/preferences/YamlExtensionManagerViewImpl.ui.xml
@@ -13,16 +13,11 @@
 <!DOCTYPE ui:UiBinder SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent">
 <ui:UiBinder xmlns:ui='urn:ui:com.google.gwt.uibinder'
              xmlns:g='urn:import:com.google.gwt.user.client.ui'
-             xmlns:svgui='urn:import:org.vectomatic.dom.svg.ui'
              xmlns:p1='urn:import:com.google.gwt.user.cellview.client'>
     <ui:with field='locale'
              type='org.eclipse.che.plugin.yaml.ide.YamlLocalizationConstant'/>
     <ui:style>
 
-        .alignRight {
-        float: right;
-        }
-
         .alignLeft {
         float: left;
         }
@@ -31,16 +26,6 @@
         margin: 6px;
         }
 
-        .space {
-        margin-left: 5px;
-        }
-
-        .button-layout {
-        min-width: 20px;
-        height: 20px;
-        padding: 0 3px;
-        }
-
         .button-layout svg {
         width: 14px;
         height: 20px;
@@ -68,7 +53,7 @@
         <g:center>
             <g:ScrollPanel addStyleNames="{style.emptyBorder}">
                 <g:SimplePanel>
-                    <p1:CellTable width="100%" ui:field="YamlPreferenceCellTable" focus="false"
+                    <p1:CellTable width="100%" ui:field="yamlPreferenceCellTable" focus="false"
                                   debugId="preferences-cellTable-keys"/>
                 </g:SimplePanel>
             </g:ScrollPanel>