Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Docker Execution #1230

Closed
TylerJewell opened this issue May 11, 2016 · 3 comments
Closed

Simplify Docker Execution #1230

TylerJewell opened this issue May 11, 2016 · 3 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@TylerJewell
Copy link

TylerJewell commented May 11, 2016

This is a tracking issue for a range of improvements that will make it simpler for people who want to run Che within a Docker container using docker run syntax.

The specification is:

  1. Change the default location of JSON storage for defining workspaces, projects and other internal models from che.conf.storage=${catalina.base}/temp/local-storage to che.conf.storage=${che.home}/storage.
  2. Change the default Docker run syntax to volume mount the ${che.home}/storage instead of the tomcat directory.
  3. Change the Dockerfile for Che to have the Entrypoint be the Che script and removing some magic around copying library files to be mounted outside of the container.
  4. Make it possible for every Che script configuration parameter to be set through an environment variable, so that they can be provided as part of docker run syntax with -e override.
  5. Allow users to override the automatic determination of the location of $CHE_HOME within the Dockerfile to use a set of Che binaries that are mounted into the container instead of those contained within it.
  6. Create a second default Vagrantfile that demonstrates the various usages of running Che in a Docker container.
  7. Deprecate the --image syntax from within the che.sh script. If you want to run Che as a docker image, you must do it manually with Docker run syntax.
  8. Add "Launch in Cloud" option for Che Docker container.
  9. Add in checks into che.sh script to detect if Docker for windows or mac is installed. If it is installed, skip the docker-machine and virtualbox steps, which are unnecessary.

@garagatyi @eivantsov @riuvshin - FYI. I'll work on issues for all of these.

@garagatyi
Copy link

garagatyi commented May 11, 2016

2 user may need to read logs also
3 we allow usage of host's docker instead of DIND? Because we need some files on host to continue support of that feature.

@TylerJewell
Copy link
Author

@garagatyi For reading log storage, I think it's starting to be seen as best practice to give user's the syntax for running a docker exec command to query the logs directly from outside the container. This is what GitLab does.

@garagatyi Yes - all of these improvements will be using host's docker instead of DIND. This already exists, but we are simplifying it further.

@ddementieva ddementieva added the kind/enhancement A feature request - must adhere to the feature request template. label Jun 3, 2016
@TylerJewell
Copy link
Author

I am closing this issue - most of these issues were resolved in other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

3 participants