Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In visible parts, replace mentions of 'oAuth', by more accurate 'OAuth' #13660

Closed
themr0c opened this issue Jul 2, 2019 · 0 comments
Closed

Comments

@themr0c
Copy link
Contributor

themr0c commented Jul 2, 2019

Description

The Eclipse Che user interface (Web UI, configuration files, logs) contains multiple mentions of oAuth, but it's supposed to be OAuth, as stated on https://oauth.net/.

Reproduction Steps

These are the occurences of oAuth that need to be changed:

  1. ./multiuser/keycloak/che-multiuser-keycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/KeycloakServiceClient.java: // we should threat this as unauthorized and send to oAuth login page.
  2. ./assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties:# You can setup GitHub oAuth to automate authentication to remote repositories.
  3. ./assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties:# You need to first register this application with GitHub oAuth.
  4. ./dashboard/src/app/workspaces/create-workspace/project-source-selector/add-import-project/import-github-project/oauth-dialog/no-github-oauth-dialog.controller.ts: * @description This class is handling the controller for the no Github oAuth dialog
  5. ./dashboard/src/app/workspaces/create-workspace/project-source-selector/add-import-project/import-github-project/oauth-dialog/no-github-oauth-dialog.html:
  6. ./dashboard/src/app/workspaces/create-workspace/project-source-selector/add-import-project/import-github-project/oauth-dialog/no-github-oauth-dialog.html:
    GitHub oAuth is not configured. {{noGithubOauthDialogController.message}}
  7. ./dashboard/src/components/api/che-o-auth-provider.factory.ts: * This class is handling the registered oAuth providers.
  8. ./dashboard/src/components/api/che-api.factory.ts: * The Che oAuth Provider API
  9. ./wsmaster/che-core-api-user-shared/src/main/java/org/eclipse/che/api/user/shared/dto/UserDto.java: @ApiModelProperty("User alias which is used for oAuth")
  10. ./wsmaster/che-core-api-auth/src/main/java/org/eclipse/che/security/oauth/OAuthAuthenticatorTokenProvider.java:/** Retrieves oAuth token with help of OAuthAuthenticatorProvider. */
  11. ./deploy/openshift/deploy_che.sh:Setup OpenShift oAuth: ${SETUP_OCP_OAUTH}
  12. ./deploy/openshift/deploy_che.sh: printInfo "Registering oAuth client in OpenShift"
  13. ./deploy/openshift/deploy_che.sh: # register oAuth client in OpenShift
  14. ./deploy/openshift/deploy_che.sh: printInfo "Registering oAuth client in Keycloak"
  15. ./deploy/openshift/deploy_che.sh: # setup Che variables related to oAuth identity provider
  16. ./deploy/openshift/templates/che-server-template.yaml: description: GitHub oAuth app client ID. Applicable to Che single user only!
  17. ./deploy/openshift/templates/che-server-template.yaml: description: GitHub oAuth app client servet. Applicable to Che single user only!
  18. ./selenium/che-selenium-test/README.md:where OPENSHIFT_TOKEN is optional and is aimed to replace username/password when OpenShift is configured with oAuth.
  19. ./ide/che-core-ide-app/src/main/resources/org/eclipse/che/ide/CoreLocalizationConstant.properties:project.import.ssh.key.upload.failed.text=We are unable to clone your repository even though you''ve configured oAuth access. \
skabashnyuk pushed a commit that referenced this issue Jan 3, 2020
…See https://oauth.net/) (#13664)

Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant