Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: incorrect handling of Enter button at workspace removing #13843

Closed
RomanNikitenko opened this issue Jul 14, 2019 · 3 comments
Closed
Labels
kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering.

Comments

@RomanNikitenko
Copy link
Member

Describe the bug

I tried to use Enter button to confirm removing of a workspace from dashboard.
The workspace was removed but two additional dialogs are came up to ask me to confirm workspace removing. Then two messages informed me that undefined has been removed

Steps to reproduce

  1. Select a workspace on dashboard
  2. Click Delete button
  3. You can see confirmation dialog:
    remove_workspace_dialog
  4. Confirm the action by pressing Enter button.

Please see the short video: https://youtu.be/-U2oOQaysww

@RomanNikitenko RomanNikitenko added the kind/bug Outline of a bug - must adhere to the bug report template. label Jul 14, 2019
@nickboldt
Copy link
Contributor

nickboldt commented Jul 15, 2019

How did you install Che? What version are you running?

What's in the workspace that you're trying to delete? Maybe you generated a workspace with something incompatible in it?

I've never seen this with Che 7 RC3 on minishift, or on che.openshift.io. Is it possible that calling your workspace che/che instead of something like wksp-java confused some back end process?

Or maybe you've confused it because your user and your workspace are both called "che" ?

@nickboldt nickboldt added the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Jul 15, 2019
@RomanNikitenko
Copy link
Member Author

Hello!
I use minikube v1.0.0 on linux (amd64), 7.0.0-rc-4.0-SNAPSHOT

What's in the workspace that you're trying to delete? Maybe you generated a workspace with something incompatible in it?

I can reproduce it for workspace that I create using stacks from dashboard.

Is it possible that calling your workspace che/che instead of something like wksp-java confused some back end process?

I don't think that is the cause of the issue.
Did you try to use Enter button (not mouse click) to confirm a workspace removing?

Please see the video: https://youtu.be/ucCQCSoFYSc

@che-bot
Copy link
Contributor

che-bot commented Jan 15, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2020
@che-bot che-bot closed this as completed Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering.
Projects
None yet
Development

No branches or pull requests

3 participants