Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to use che-theia-generator to match with specific Theia version #13978

Closed
4 of 23 tasks
AndrienkoAleksandr opened this issue Jul 23, 2019 · 5 comments
Closed
4 of 23 tasks

Add ability to use che-theia-generator to match with specific Theia version #13978

AndrienkoAleksandr opened this issue Jul 23, 2019 · 5 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Milestone
7.2.0

Comments

@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Jul 23, 2019 •
edited
Loading

Describe the bug

Currently we are using che-theia-generator with hard-coded latest configuration of the che-theia https://github.com/ws-skeleton/che-theia-generator/blob/master/src/templates/assembly-package.mst. But configuration generated in such way could be broken when we build che-theia with older theia branch(f.e. for theia v0.7.0). Hard-coded configuration could contains newer extension/s which we don't have in the older theia version and build of che-theia fail.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

Expected behavior

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context
@AndrienkoAleksandr AndrienkoAleksandr added kind/bug Outline of a bug - must adhere to the bug report template. team/ide2 kind/enhancement A feature request - must adhere to the feature request template. labels Jul 23, 2019
@benoitf
Copy link
Contributor

benoitf commented Jul 23, 2019

AFAIK generator will be part of che-theia so it should ease that ?

@AndrienkoAleksandr
Copy link
Contributor Author

AFAIK generator will be part of che-theia so it should ease that ?

I think yes.

@nickboldt
Copy link
Contributor

So... is this something that will be changed over from the ws-skeleton to the che-theia repo? Are we talking about a PoC now, and something fixed in che-theia upstream later?

I'm confused what the issue is and what the solution will be. Also on priority. Need help w/ triage here.

@nickboldt nickboldt added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 24, 2019
@slemeur slemeur removed the kind/bug Outline of a bug - must adhere to the bug report template. label Jul 24, 2019
@slemeur slemeur changed the title Add ability to use che-theia-generator matched with concrete Theia version. Add ability to use che-theia-generator to match with specific Theia version Jul 24, 2019
@slemeur slemeur added this to the 7.2.0 milestone Jul 24, 2019
@nickboldt
Copy link
Contributor

@slemeur if you think this needs to be in 7.2, then it's been triaged. removing the status/need-triage label

@nickboldt nickboldt removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 31, 2019
@benoitf benoitf added the status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. label Jul 31, 2019
@evidolob
Copy link
Contributor

As now generator inside che-theia repository, there are nothing to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
Projects
None yet
Milestone
7.2.0
Development

No branches or pull requests
5 participants
@nickboldt @benoitf @evidolob @slemeur @AndrienkoAleksandr