Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task editor should properly handle the che commands syntax #13984

Closed
2 of 23 tasks
apupier opened this issue Jul 24, 2019 · 4 comments
Closed
2 of 23 tasks

Task editor should properly handle the che commands syntax #13984

apupier opened this issue Jul 24, 2019 · 4 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach
Milestone
7.5.0

Comments

@apupier
Copy link
Contributor

apupier commented Jul 24, 2019

Describe the bug

Error reported for provided tasks in stack "Value is not accepted. Valid values: "process", "shell"."

Che version

Che-Theia@4ef1d89 using Theia@4ef1d89

Steps to reproduce

  1. Create a workspace from Apache Camel stack for isntance
  2. Click on Terminal -> Configure Tasks... -> select "che: run the services"
  3. an error is mentioned on the type "che"

Expected behavior

no error on provided tasks

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify) https://che.prod-preview.openshift.io

Screenshots

image

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context
@apupier
Copy link
Contributor Author

apupier commented Jul 24, 2019

please note that the command is working well when executed

@apupier apupier added the kind/bug Outline of a bug - must adhere to the bug report template. label Jul 24, 2019
@amisevsk amisevsk added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 24, 2019
@amisevsk
Copy link
Contributor

It appears that the "type" field is filled when getting the command from the devfile. Issue is present in all devfiles I've checked.

@slemeur
Copy link
Contributor

slemeur commented Jul 24, 2019

Yes I reported to the team the same problem today as well.
It is defined here: https://github.com/theia-ide/theia/blob/master/packages/task/src/browser/task-schema-updater.ts#L123
But not extended for the sake of che-theia.

@slemeur slemeur changed the title Error reported for provided tasks in stack "Value is not accepted. Valid values: "process", "shell"." Task editor should properly handle the che commands syntax Jul 24, 2019
@slemeur slemeur added kind/enhancement A feature request - must adhere to the feature request template. and removed kind/bug Outline of a bug - must adhere to the bug report template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 24, 2019
@slemeur slemeur added this to the 7.2.0 milestone Jul 24, 2019
@vparfonov vparfonov mentioned this issue Aug 7, 2019
Closed
11 tasks
@vparfonov vparfonov added severity/P2 Has a minor but important impact to the usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach labels Aug 15, 2019
@vparfonov vparfonov modified the milestones: 7.2.0, 7.x Oct 2, 2019
@RomanNikitenko RomanNikitenko mentioned this issue Nov 19, 2019
Merged
@vparfonov vparfonov modified the milestones: 7.x, Backlog - IDE 1 Nov 20, 2019
@vparfonov vparfonov mentioned this issue Nov 26, 2019
Closed
19 tasks
@vparfonov vparfonov modified the milestones: Backlog - IDE 1, 7.5.0 Nov 26, 2019
@RomanNikitenko
Copy link
Member

I added schema for che tasks within eclipse-che/che-theia#550
Now content assistant should work for che tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach
Projects
None yet
Milestone
7.5.0
Development

No branches or pull requests
5 participants
@apupier @vparfonov @slemeur @RomanNikitenko @amisevsk