Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin registry] Improvements to build process #14736

Closed
nickboldt opened this issue Oct 1, 2019 · 2 comments
Closed

[plugin registry] Improvements to build process #14736

nickboldt opened this issue Oct 1, 2019 · 2 comments
Labels
area/install Issues related to installation, including offline/air gap and initial setup area/plugin-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
Backlog - Product...

Comments

@nickboldt
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

Based on feedback in eclipse-che/che-plugin-registry#232 there are some things we can do to to improve the build process.

Describe the solution you'd like

  • move dockerfiles and related meta files (*.repo) into build/dockerfiles/
  • remove Listen 80,Listen 8080 replacement instruction
  • probably not needed: chmod a+rwX /etc/httpd/conf /run/httpd
  • For the non-rhel dockerfile, this could be implemented as an ARG (ONLY_LATEST=true) to avoid having to edit the dockerfile for specific builds.
@nickboldt nickboldt added the kind/enhancement A feature request - must adhere to the feature request template. label Oct 1, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 1, 2019
@nickboldt nickboldt added area/install Issues related to installation, including offline/air gap and initial setup area/plugin-registry team/productization and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 1, 2019
@nickboldt nickboldt added this to the Backlog - Productization milestone Oct 1, 2019
@benoitf
Copy link
Contributor

benoitf commented Oct 1, 2019

you'll use build scripts to copy some content to have access to other files (like Che) or you'll keep root docker context

also I would suggest build/dockerfile/rhel/ so you've dedicated files for rhel there and you can name the Dockerfile Dockerfile for your vscode extension

@benoitf benoitf added the severity/P2 Has a minor but important impact to the usage or development of the system. label Oct 2, 2019
@nickboldt
Copy link
Contributor Author

This was all done some time ago.

https://github.com/eclipse/che-plugin-registry/tree/master/build/dockerfiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/install Issues related to installation, including offline/air gap and initial setup area/plugin-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
Backlog - Productization
Development

No branches or pull requests
3 participants
@nickboldt @benoitf @che-bot