Git clone fails but success message is shown

[l0rd]

Describe the bug

The message project cloned is shown even if the clone has failed at the startup of a workspace.

I expected to see an error instead. And when the error is Permission denied (publickey) it should propose me to upload the SSH key and retry the cloning.

Che version

nightly

Steps to reproduce

1. Select Add Workspace
2. Select a stack
3. Replace the repository URL with a git + ssh one (for example git@github.com:che-incubator/chectl.git)

Runtime

$ minikube version
minikube version: v1.4.0
commit: 7969c25a98a018b94ea87d949350f3271e9d64b6
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.0", GitCommit:"ddf47ac13c1a9483ea035a79cd7c10005ff21a6d", GitTreeState:"clean", BuildDate:"2018-12-04T07:48:45Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.0", GitCommit:"2bd9643cee5b3b3a5ecbd3af49d09018f0773c77", GitTreeState:"clean", BuildDate:"2019-09-18T14:27:17Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

Screenshots

Success messages are shown, everything looks fine

But no project is here

And looking at Theia logs we find out that there was an error when doing the git clone

root ERROR [hosted-plugin: 48] Child process git stderr: Cloning into '/projects/chectl'...
root INFO [nsfw-watcher: 31] Started watching: /projects/.theia/tasks.json
root ERROR [hosted-plugin: 48] TypeError: Converting circular structure to JSON
    at JSON.stringify (<anonymous>)
    at Function.MessageFactory.request (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:326:166)
    at RPCProtocolImpl.remoteCall (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:153:46)
    at Proxy.target.(anonymous function) (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:126:38)
    at SourceControlImpl.set [as statusBarCommands] (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/scm.js:330:24)
    at Repository.statusBar.onDidChange (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:420:75)
    at i (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/util.js:53:83)
    at /home/theia/node_modules/@theia/core/lib/common/event.js:162:33
    at CallbackList.invoke (/home/theia/node_modules/@theia/core/lib/common/event.js:177:39)
    at Emitter.fire (/home/theia/node_modules/@theia/core/lib/common/event.js:265:29)
root ERROR [hosted-plugin: 48] TypeError: Converting circular structure to JSON
    at JSON.stringify (<anonymous>)
    at Function.MessageFactory.request (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:326:166)
    at RPCProtocolImpl.remoteCall (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:153:46)
    at Proxy.target.(anonymous function) (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:126:38)
    at SourceControlImpl.set [as statusBarCommands] (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/scm.js:330:24)
    at Repository.statusBar.onDidChange (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:420:75)
    at i (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/util.js:53:83)
    at /home/theia/node_modules/@theia/core/lib/common/event.js:162:33
    at CallbackList.invoke (/home/theia/node_modules/@theia/core/lib/common/event.js:177:39)
    at Emitter.fire (/home/theia/node_modules/@theia/core/lib/common/event.js:265:29)
root ERROR [hosted-plugin: 48] TypeError: Converting circular structure to JSON
    at JSON.stringify (<anonymous>)
    at Function.MessageFactory.request (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:326:166)
    at RPCProtocolImpl.remoteCall (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:153:46)
    at Proxy.target.(anonymous function) (/home/theia/node_modules/@theia/plugin-ext/lib/common/rpc-protocol.js:126:38)
    at SourceControlImpl.set [as statusBarCommands] (/home/theia/node_modules/@theia/plugin-ext/lib/plugin/scm.js:330:24)
    at Repository.statusBar.onDidChange (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/repository.js:420:75)
    at i (/tmp/vscode-unpacked/vscode-git-1.3.0.1.vsix/extension/out/util.js:53:83)
    at /home/theia/node_modules/@theia/core/lib/common/event.js:162:33
    at CallbackList.invoke (/home/theia/node_modules/@theia/core/lib/common/event.js:177:39)
    at Emitter.fire (/home/theia/node_modules/@theia/core/lib/common/event.js:265:29)
root ERROR [hosted-plugin: 48] Child process git stderr: Warning: Permanently added 'github.com,140.82.118.4' (RSA) to the list of known hosts.
root ERROR [hosted-plugin: 48] Child process git stderr: git@github.com: Permission denied (publickey).
root ERROR [hosted-plugin: 48] Child process git stderr: fatal: Could not read from remote repository.

Installation method

$ chectl server:start --platform minikube --installer helm

Environment

my computer / macOS