Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually verify that git+SSH with devfile works flawlessly #14794

Closed
5 tasks
vparfonov opened this issue Oct 7, 2019 · 9 comments
Closed
5 tasks

Manually verify that git+SSH with devfile works flawlessly #14794

vparfonov opened this issue Oct 7, 2019 · 9 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@vparfonov
Copy link
Contributor

vparfonov commented Oct 7, 2019

This issue about testing that you can create a devfile pointing to ssh repo and making sure that it works properly:

  • workspace is created
  • source code is cloned
  • user can push

And the corner cases: Improve error message during git push/clone #14615

  • if user is not authorized to clone, it raises an error message
  • if user does not have an ssh key configured, it raises an error
@vparfonov vparfonov added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Oct 7, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 7, 2019
@vparfonov vparfonov self-assigned this Oct 7, 2019
@vparfonov
Copy link
Contributor Author

At the moment if user have well configured SSH settings:

  • have generated/uploaded SSH keys in Che;
  • put public part to the Git provider

@tolusha
Copy link
Contributor

tolusha commented Oct 7, 2019

@vparfonov
Not clear, are talking project url? like this git@github.com:eclipse/che.git ?

@tolusha tolusha added the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Oct 7, 2019
@l0rd
Copy link
Contributor

l0rd commented Oct 7, 2019

@vparfonov I have already opened an issue about the corner case "if user in not authorized to clone, it raises an error message" #14775. Hence I consider that fixing that issue is a prerequisite to this one.

@vparfonov
Copy link
Contributor Author

@vparfonov
Not clear, are talking project url? like this git@github.com:eclipse/che.git ?

Yes

@tolusha tolusha added severity/P1 Has a major impact to usage or development of the system. team/ide2 and removed status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. team/ide2 status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 8, 2019
@tolusha
Copy link
Contributor

tolusha commented Oct 8, 2019

/cc @rhopp @dmytro-ndp

@vparfonov vparfonov changed the title Verify that starting a workspace from a devfile works flawlessly Verify that starting a workspace from a devfile works flawlessly with SSH git url to the project repositories Oct 10, 2019
@musienko-maxim
Copy link
Contributor

@vparfonov, @l0rd For implementing the test for this workflow we need to clarity:
When should launch the ci- job (every day, every release, every PR ) on which repos (che, che-theia) and infra (k8s, openshift).

@l0rd
Copy link
Contributor

l0rd commented Oct 10, 2019

I don't think that the goal was to create an automated test but just a task for IDE1 team to validate that the whole git+ssh flow works fine cc @slemeur

But I think that it's actually a good idea @musienko-maxim to use git+ssh in the happy path PR check cc @rhopp. @musienko-maxim if you agree with that please open a separate issue for that.

@l0rd l0rd added this to the Backlog - IDE 1 milestone Oct 11, 2019
@l0rd l0rd changed the title Verify that starting a workspace from a devfile works flawlessly with SSH git url to the project repositories Manually verify that git+SSH with devfile works flawlessly Oct 11, 2019
@nickboldt
Copy link
Contributor

nickboldt commented Oct 15, 2019

Latest news from our airgap tester using Che 7.2. The following workflow works.

  1. start empty workspace. generate ssh key pair...
  2. upload new key to private airgapped github instance for each user
  3. open devfile w/ ref to private airgapped github instance project, using git@repo:username/project.git format
  4. project code loads! user can pull and push to private airgapped github instance

Devfile:

image

Initial load of workspace + readme file (including intentional typo):

image

After pushing a change in the workspace to the repo (fix typo), new workspace loads with change applied:

image

@vparfonov
Copy link
Contributor Author

If user already has SSh key:

  • workspace is created
  • source code is cloned
  • user can push

If not:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants