Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chectl is not compliant with the codeready deployment flavor / stucks at the PostgreSQL pod bootstrap (Post installation checklist) #14963

Closed
5 of 7 tasks
ibuziuk opened this issue Oct 23, 2019 · 12 comments
Assignees
Labels
area/chectl Issues related to chectl, the CLI of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Oct 23, 2019

chectl stucks at the PostgreSQL pod bootstrap (Post installation checklist)

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. start crc
  2. chectl server:start -a operator -p crc -b console-openshift-console.apps-crc.testing -n crw --che-operator-image=quay.io/ibuziuk/che-operator:che-14809 --che-operator-cr-yaml=crw.yaml
  3. ERROR:
  ✔ Verify Kubernetes API...OK (it's OpenShift)
  ✔ 👀  Looking for an already existing Che instance
    ✔ Verify if Che is deployed into namespace "crw"...it is not
  ✔ ✈️  CodeReady Containers preflight checklist
    ✔ Verify if oc is installed...done.
    ✔ Verify if crc is installed...done.
    ✔ Verify if CodeReady Containers is running...done.
    ✔ Retrieving CodeReady Containers IP and domain for routes URLs...192.168.130.11.nip.io.
 ›   Warning: Che will be deployed in Multi-User mode since Configured 'operator' installer which support only such.
  ✔ 🏃‍  Running the Che Operator
    ✔ Copying operator resources...done.
    ✔ Create Namespace (crw)...done.
    ✔ Create ServiceAccount che-operator in namespace crw...done.
    ✔ Create Role che-operator in namespace crw...done.
    ✔ Create ClusterRole che-operator...It already exists.
    ✔ Create RoleBinding che-operator in namespace crw...done.
    ✔ Create ClusterRoleBinding che-operator...It already exists.
    ✔ Create CRD checlusters.org.eclipse.che...It already exists.
    ✔ Waiting 5 seconds for the new Kubernetes resources to get flushed...done.
    ✔ Create deployment che-operator in namespace crw...done.
    ✔ Create Che Cluster eclipse-che in namespace crw...done.
  ❯ ✅  Post installation checklist
    ❯ PostgreSQL pod bootstrap
      ✖ scheduling
        → ERR_TIMEOUT: Timeout set to pod wait timeout 300000. podExist: false, currentPhase: undefined
        downloading images
        starting
      Keycloak pod bootstrap
      Devfile registry pod bootstrap
      Plugin registry pod bootstrap
      Che pod bootstrap
      Retrieving Che Server URL
      Che status check
Error: ERR_TIMEOUT: Timeout set to pod wait timeout 300000. podExist: false, currentPhase: undefined
    at KubeHelper.<anonymous> (~/.local/share/chectl/client/7.3.0/lib/api/kube.js:598:19)
    at Generator.next (<anonymous>)
    at fulfilled (~/.local/share/chectl/client/7.3.0/node_modules/tslib/tslib.js:107:62)

But in reality the pod started:

Screenshots

image

Also, there is hardcoded route names
https://github.com/che-incubator/chectl/blob/master/src/api/che.ts#L111 which fails start of workspace in CRW.

Screenshot from 2019-10-25 10-11-06

Runtime

  • crc

Expected behavior

che is started against crc without errors - all checks in the checklist should pass

Runtime

  • crc

Installation method

  • chectl

Environment

  • Fedora 30
@ibuziuk ibuziuk added the kind/bug Outline of a bug - must adhere to the bug report template. label Oct 23, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 23, 2019
@sleshchenko
Copy link
Member

@ibuziuk thanks for reporting it. It happens because of labels mismatching: chectl expects 'app=che,component=postgres' while crc postgres has 'app=codeready,component=postgres'
https://github.com/che-incubator/chectl/blob/master/src/tasks/che.ts#L38

@sleshchenko sleshchenko added the area/chectl Issues related to chectl, the CLI of Che label Oct 23, 2019
@ibuziuk
Copy link
Member Author

ibuziuk commented Oct 23, 2019

@sleshchenko ah, ok - so looks like chectl is not compliant with the codeready deployment flavour

@ibuziuk ibuziuk changed the title chectl stucks at the PostgreSQL pod bootstrap (Post installation checklist) chectl is not compliant with the codeready deployment flavor / stucks at the PostgreSQL pod bootstrap (Post installation checklist) Oct 23, 2019
@ibuziuk
Copy link
Member Author

ibuziuk commented Oct 23, 2019

building custom "codeready" compatible chectl seem to work fine against crc (replacing "che" lable with "codeready")

@benoitf benoitf added severity/P1 Has a major impact to usage or development of the system. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 23, 2019
@benoitf
Copy link
Contributor

benoitf commented Oct 23, 2019

hello, is someone already working on a fix ?

@ibuziuk
Copy link
Member Author

ibuziuk commented Oct 24, 2019

no, I just build a custom binary by replacing che labels with codeready, but I can take care of this issue

@rhopp
Copy link
Contributor

rhopp commented Oct 24, 2019

Downstream issue: https://issues.jboss.org/browse/CRW-437

@benoitf
Copy link
Contributor

benoitf commented Oct 24, 2019

@ibuziuk OK so I should assign osio team backlog ?

@nickboldt
Copy link
Contributor

nickboldt commented Oct 24, 2019

See also https://issues.jboss.org/browse/CRW-328 re: productized chectl. If we need to create a new https://github.com/redhat-developer/codeready-workspaces-chectl repo, I can do so. Otherwise you can create a folder in https://github.com/redhat-developer/codeready-workspaces/blob/master/dependencies/

But ideally this would be fixed in upstream so we can just override w/ custom-resource.yaml

@ibuziuk
Copy link
Member Author

ibuziuk commented Oct 24, 2019

@nickboldt @benoitf che/osio can prioritize this issue for the next sprint
@l0rd wdyt? I believe we do not need to cretate specific codeready-workspaces-chectl (vanilla chectl can handle both falvours )

@ibuziuk ibuziuk removed the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Oct 24, 2019
@ibuziuk ibuziuk added this to the 7.3.1 milestone Oct 24, 2019
@ibuziuk ibuziuk self-assigned this Oct 24, 2019
@ibuziuk
Copy link
Member Author

ibuziuk commented Oct 25, 2019

    ✔ Keycloak pod bootstrap
      ✔ scheduling...done.
      ✔ downloading images...done.
      ✔ starting...done.
    ✔ Devfile registry pod bootstrap
      ✔ scheduling...done.
      ✔ downloading images...done.
      ✔ starting...done.
    ✔ Plugin registry pod bootstrap
      ✔ scheduling...done.
      ✔ downloading images...done.
      ✔ starting...done.
    ✔ Che pod bootstrap
      ✔ scheduling...done.
      ✔ downloading images...done.
      ✔ starting...done.
    ✔ Retrieving Che Server URL...https://codeready-eclipse-che.apps-crc.testing
    ✔ Che status check
Command server:start has completed successfully.

Changes required for making chectl codereaady specific - https://github.com/che-incubator/chectl/compare/master...ibuziuk:che-14963?expand=1

@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 6, 2019

Closing, the initial implementation of CRW specific chectl (crwctl is available) in https://github.com/redhat-developer/codeready-workspaces-chectl

@ibuziuk ibuziuk closed this as completed Nov 6, 2019
@dmytro-ndp
Copy link
Contributor

Downstream issue: https://issues.jboss.org/browse/CRW-463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chectl Issues related to chectl, the CLI of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

7 participants