Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to load devfile should load the devfile from the appropriate branch #17448

Closed
4 of 22 tasks
edeandrea opened this issue Jul 20, 2020 · 3 comments
Closed
4 of 22 tasks
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.

Comments

@edeandrea
Copy link

edeandrea commented Jul 20, 2020

Describe the bug

Che version

  • latest - 7.15.2
  • nightly
  • other: please specify

Steps to reproduce

  1. Log into OpenShift cluster as cluster admin
  2. Deploy the che operator as well as a CheCluster instance, then wait for it to spin up
  3. If logged in as administrator, on left side menu change 'adminstrator' to 'developer' to show topology link on left nav bar.
  4. Click +Add
  5. Click From Git
  6. In the Git Repo URL field, enter https://github.com/edeandrea/summit-lab-spring-music
  7. Expand Show Advanced Git Options
  8. In the Git Reference field, enter pipeline
  9. In the Resources section, select Deployment Config
  10. In the Advanced Options section, click the word Labels and enter the label app.openshift.io/runtime=spring and hit enter
  11. Click Create
  12. Wait for build & deployment to complete
  13. Click the che logo on the deployment (see attached screenshot)

Expected behavior

After going through the steps to reproduce above, the URL that is generated for the icon is https://<che-url>/dashboard/#/load-factory/?url=https://github.com/edeandrea/summit-lab-spring-music&policies.create=peruser but it should be https://<che-url>/dashboard/#/load-factory/?url=https://github.com/edeandrea/summit-lab-spring-music/tree/pipeline&policies.create=peruser since the application was added using the pipeline branch. It should respect that and hence load the workspace using the devfile on the pipeline branch and not the master branch.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)
Client Version: openshift-clients-4.4.0-202004250654
Server Version: 4.3.13
Kubernetes Version: v1.16.2

Screenshots

Screen Shot 2020-07-20 at 3 55 20 PM

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify
@edeandrea edeandrea added the kind/bug Outline of a bug - must adhere to the bug report template. label Jul 20, 2020
@edeandrea edeandrea changed the title Link to load devfile should contain the appropriate branch info Link to load devfile should load the devfile from the appropriate branch Jul 20, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 20, 2020
@skabashnyuk
Copy link
Contributor

Hello @edeandrea . thank you for this report. As I can see the link is generated on OpenShift Console https://github.com/openshift/console/ . I belive the issue has to be created here https://github.com/openshift/console/issues

@skabashnyuk skabashnyuk added kind/question Questions that haven't been identified as being feature requests or bugs. and removed kind/bug Outline of a bug - must adhere to the bug report template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 21, 2020
@edeandrea
Copy link
Author

edeandrea commented Jul 22, 2020

Thanks @skabashnyuk - I've also posted this as openshift/console#6077

@sleshchenko
Copy link
Member

Closing it since after link is changed on OpenShift Console side everything should work as expected. Tested on https://che.openshift.io/dashboard/#/load-factory/?url=https://github.com/edeandrea/summit-lab-spring-music/tree/pipeline&policies.create=peruse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.
Projects
None yet
Development

No branches or pull requests

4 participants