Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize devworkspace client #19071

Closed
sleshchenko opened this issue Feb 15, 2021 · 2 comments
Closed

Initialize devworkspace client #19071

sleshchenko opened this issue Feb 15, 2021 · 2 comments
Assignees
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@sleshchenko
Copy link
Member

Is your task related to a problem? Please describe.

DevWorkspace + Dashboard integration depends on the https://github.com/JPinkney/devworkspace-client
And we should move it somewhere in a common place.

From DevWorkspace Cabal meeting:
we're not sure that we need that library on devfile side at this point, so the option that we chose for start http://github.com/che-incubator/devworkspace-che-client (or che-devworkspace-client but we already have https://github.com/che-incubator/devworkspace-che-operator)

That library should have a methods to work with DevWorkspace or DevWorkspaceTemplates.
We keep in mind that we may need later migrate it to devfile organization, or it should keep be Che independent:

  • K8s API endpoint (dashboard can configure Che Server unsupported, che theia can configure K8s API directly)
  • namespace (Theia use DEVWORKSPACE_NAMESPACE env var, Dashboard use value from Che Server default namespace)
  • authentication: token should be parameter, Dashboard does not specify it(Che Server handles it), Che Theia specifies it from /var/.../serviceaccount/token);

In addition, this library can have Che dependent functions, like resolve DevWorkspaceTemplate from che editor reference.

@sleshchenko sleshchenko added kind/task Internal things, technical debt, and to-do tasks to be performed. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Feb 15, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 15, 2021
@benoitf
Copy link
Contributor

benoitf commented Feb 15, 2021

For now this library (current code that I can browse at https://github.com/JPinkney/devworkspace-client) can't be used for che-theia as it's using /api/unsupported/k8s and che-theia has no idea about che-api server
Also che-theia is server side and has access to K8s api directly so no need to use http/axios layer with proxy stuff.

@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 15, 2021
@sleshchenko sleshchenko added this to the 7.27 milestone Mar 2, 2021
@sleshchenko
Copy link
Member Author

The described library is initialized but it's needed to check what is missing and create dedicated issues for found items if any https://github.com/che-incubator/devworkspace-client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants