Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report realistic code coverage for che-theia repo #19130

Closed
2 tasks
vzhukovs opened this issue Feb 23, 2021 · 3 comments · Fixed by eclipse-che/che-theia#1007 or eclipse-che/che-theia#1030
Closed
2 tasks
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@vzhukovs
Copy link
Contributor

vzhukovs commented Feb 23, 2021

Is your task related to a problem? Please describe.

At the moment, code-coverage is not providing the right information: we have extensions and plugins with no test and these ones should be counted in the overall che-theia codecoverage metric.

The following epic should represent the state of test coverage across main che-theia parts, e.g. extensions and plugins.
For the packages, that are not configured to have unit testing support should be created the particular configuration, e.g. jest, mocka + sinon, etc.

In the following section will provide the packages that should be processed to have the mechanism which will display the test coverage:

  • extensions/*
  • plugins/*

This is the next step after creating the mechanism which measures the test coverage across che-theia repository.

@vzhukovs vzhukovs added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che area/plugins Epic labels Feb 23, 2021
@sunix sunix changed the title Test coverage for che-theia extensions and plugins Display realistic code coverage for che-theia repo. Feb 23, 2021
@sunix sunix changed the title Display realistic code coverage for che-theia repo. Report realistic code coverage for che-theia repo. Feb 23, 2021
@sunix
Copy link
Contributor

sunix commented Feb 23, 2021

I suggest that we split that in 2 main steps:

  • 1. configure jest to produce test reports for all plugins + renaming the badge plugins code-coverage: xx%
  • 2. configure jest to produce test reports for all the extensions + renaming the badge coverage: xx%

@azatsarynnyy
Copy link
Member

I suggest that we split that in 2 main steps:

  • 1. configure jest to produce test reports for all plugins + renaming the badge plugins code-coverage: xx%
  • 2. configure jest to produce test reports for all the extensions + renaming the badge coverage: xx%

I wonder what the purpose of such separation? More badges in the readme file?
We used to have a separate repo for each extension/plug-in.
Today, Che-Theia is a project that contains all its parts in a single repository.
Why we would need separate badges for different folders in a single repo?

@sunix
Copy link
Contributor

sunix commented Feb 26, 2021

@azatsarynnyy no the same badge but labeled differently based on the coverage it is really showing.

At the moment, it is showing wrong value, we don't have 59% code coverage. If we want to do it step by step, at least we should tell what we are really showing.

@vzhukovs vzhukovs changed the title Report realistic code coverage for che-theia repo. Report realistic code coverage for che-theia repo Mar 3, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Mar 4, 2021
11 tasks
@vzhukovs vzhukovs removed the Epic label Mar 4, 2021
@azatsarynnyy azatsarynnyy modified the milestones: 7.27, 7.28 Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
4 participants