Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vale plugin to version v2.10.2 #19289

Closed
4 of 22 tasks
themr0c opened this issue Mar 15, 2021 · 3 comments
Closed
4 of 22 tasks

Update vale plugin to version v2.10.2 #19289

themr0c opened this issue Mar 15, 2021 · 3 comments
Assignees
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone

Comments

@themr0c
Copy link
Contributor

themr0c commented Mar 15, 2021

Describe the bug

In che-docs, we had issues with vale 2.8.0 that were solved by upgrading vale to 2.10.0 in che-docs container.

Can you upgrade also the vale plug-in container?

shell in vale plug-in:

/projects/che-docs $ vale che-docs/CONTRIBUTING.adoc 
E100 [NewE201] Runtime error
error parsing regexp: invalid or unsupported Perl syntax: `(?!`
Execution stopped with code 1.
/projects/che-docs $ vale -v
vale version v2.8.0

vs. shell in che-docs container (with vale 2.10.0):

~/che-docs $ vale che-docs/CONTRIBUTING.adoc 
✖ 10 errors, 14 warnings and 62 suggestions in 1 file.
~/che-docs $ vale  -v
vale version master

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Open the che-docs project in wokspaces.openshift.com
  2. Open an AsciiDoc file, for example CONTRIBUTING.adoc
  3. Activate the Problems view: no vale errors are reported.
  4. Open shell in vale plug-in, run vale che-docs/CONTRIBUTING.adoc
  5. Open shell in che-docs container, run vale che-docs/CONTRIBUTING.adoc

Expected behavior

Vale errors are reported in the Problems view.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify) workspaces.openshift.com
  • other: please specify
@themr0c themr0c added kind/bug Outline of a bug - must adhere to the bug report template. area/plugins labels Mar 15, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 15, 2021
@ScrewTSW ScrewTSW added severity/P2 Has a minor but important impact to the usage or development of the system. severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 15, 2021
@ericwill ericwill mentioned this issue Mar 18, 2021
46 tasks
@vinokurig vinokurig self-assigned this Mar 22, 2021
@vinokurig
Copy link
Contributor

@themr0c
When I run vale /projects/che-docs/CONTRIBUTING.adoc I see an error:

~/vale $ vale /projects/che-docs/CONTRIBUTING.adoc 
E100 [loadStyles] Runtime error

style 'write-good' does not exist on StylesPath

Execution stopped with code 1.
~/vale $ vale --v
vale version v2.8.0
~/vale $ 

@ericwill ericwill added this to the 7.29 milestone Mar 24, 2021
@vinokurig
Copy link
Contributor

Fixed by eclipse-che/che-plugin-registry#895

@l0rd l0rd changed the title vale plug-in: update vale to the latest version Update vale plugin to version v2.10.2 Apr 13, 2021
@l0rd l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Apr 13, 2021
@nickboldt
Copy link
Contributor

Upstream only, no vale in CRW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

7 participants