Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase default size of the persistent volume claim for workspaces #19314

Closed
tolusha opened this issue Mar 17, 2021 · 4 comments
Closed

Increase default size of the persistent volume claim for workspaces #19314

tolusha opened this issue Mar 17, 2021 · 4 comments
Assignees
@AndrienkoAleksandr
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.29

Comments

@tolusha
Copy link
Contributor

tolusha commented Mar 17, 2021

Is your task related to a problem? Please describe.

Currently pvcClaim size is 1Gi [1]
It is not enough for common pvcStrategy in most cases.

Describe the solution you'd like

The default value should be increased.

Additional context

[1] https://github.com/eclipse-che/che-operator/blob/master/deploy/crds/org_v1_che_cr.yaml#L91-L96
@tolusha tolusha added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Mar 17, 2021
@ibuziuk
Copy link
Member

ibuziuk commented Mar 17, 2021 •
edited

👍 let's make it 10 to be identical with the workspaces.openshift.com configuration pvcClaimSize: 10Gi

@tolusha tolusha added this to the 7.29 milestone Mar 18, 2021
@tolusha tolusha mentioned this issue Mar 23, 2021
Closed
38 tasks
@sleshchenko
Copy link
Member

A bit out of the current issue but qood question: We're able to change the existing PVC size? If no - it is clear from CheCluster CRD?

@tolusha
Copy link
Contributor Author

tolusha commented Mar 24, 2021

It is possible by setting: spec.Storage.PvcClaimSize

@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Mar 25, 2021
@sleshchenko
Copy link
Member

sleshchenko commented Mar 26, 2021 •
edited

I mean is Che Server is able to modify claimSize for already created PVCs, after Che Operator prodives the new value.

Update: it depends on the storage type, if it supports allowVolumeExpansion, then PVC can be expanded to newer size.

@AndrienkoAleksandr AndrienkoAleksandr mentioned this issue Mar 26, 2021
Merged
11 tasks
@tolusha tolusha closed this as completed Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrienkoAleksandr AndrienkoAleksandr

Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.29
Development

No branches or pull requests
4 participants
@ibuziuk @tolusha @sleshchenko @AndrienkoAleksandr