Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "shellcheck" plugin doesn't work #19376

Closed
19 tasks
Ohrimenko1988 opened this issue Mar 23, 2021 · 6 comments
Closed
19 tasks

The "shellcheck" plugin doesn't work #19376

Ohrimenko1988 opened this issue Mar 23, 2021 · 6 comments
Assignees
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/current
Milestone

Comments

@Ohrimenko1988
Copy link
Contributor

Ohrimenko1988 commented Mar 23, 2021

Describe the bug

The "shellcheck" plugin doesn't work

Che version

  • latest
  • [ x ] nightly
  • other: please specify

Steps to reproduce

Expected behavior:

  • Warning highlighting in the 5th row
  • Warning highlighting disappeared after uncommenting 3rd line

Observed behavior:

  • Shellcheck features don't work

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • [ x ] minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • [ x ] chectl
./chectl server:deploy \
  --k8spodreadytimeout=600000 \
  --k8spodwaittimeout=600000 \
  --k8spoddownloadimagetimeout=600000 \
  --listr-renderer=verbose \
  --platform=minikube \
  --chenamespace=iokhrime-che \
  --telemetry=off
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • [ x ] Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • Dev Sandbox (workspaces.openshift.com)
  • other: please specify

Eclipse Che Logs

Additional context

@Ohrimenko1988 Ohrimenko1988 added the kind/bug Outline of a bug - must adhere to the bug report template. label Mar 23, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 23, 2021
@vzhukovs vzhukovs added area/plugins severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 23, 2021
@ericwill ericwill mentioned this issue Mar 24, 2021
46 tasks
@ericwill ericwill added this to the 7.29 milestone Mar 24, 2021
@ericwill
Copy link
Contributor

ericwill commented Apr 8, 2021

I tested the latest plugin and it's working fine. It was most likely fixed by: eclipse-che/che-plugin-registry#905

@ericwill ericwill closed this as completed Apr 8, 2021
@Ohrimenko1988
Copy link
Contributor Author

Ohrimenko1988 commented Apr 9, 2021

Still reproducing on my environment:

Screenshot from 2021-04-09 15-12-09

And here is a used nightly image
Screenshot from 2021-04-09 15-17-09

@Ohrimenko1988 Ohrimenko1988 reopened this Apr 9, 2021
@Ohrimenko1988
Copy link
Contributor Author

I also configured preferences:
Screenshot from 2021-04-09 15-08-58

@ericwill ericwill mentioned this issue Apr 13, 2021
42 tasks
@ericwill ericwill modified the milestones: 7.29, 7.30 Apr 14, 2021
@tsmaeder
Copy link
Contributor

I can reproduce the problem on the dogfooding instance against both che-theia:latest and che-theia:next, but not in a self-hosting setup.

@tsmaeder
Copy link
Contributor

I noticed something weird inside the shellcheck sidecar: . The user is

  1. the $HOME variable points to /
  2. The user in the shell is user
  3. The root directory is not writeable.

All of this could very well lead to the plugin not working correctly.

@ericwill
Copy link
Contributor

@tsmaeder is this issue done now?

@tsmaeder tsmaeder closed this as completed May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

5 participants