Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to update che-operator on OCP 4.8 #19436

Closed
3 tasks done
tolusha opened this issue Mar 29, 2021 · 5 comments
Closed
3 tasks done

Failed to update che-operator on OCP 4.8 #19436

tolusha opened this issue Mar 29, 2021 · 5 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@tolusha
Copy link
Contributor

tolusha commented Mar 29, 2021

Describe the bug

Failed to update che-operator from 7.27.2 to 7.28.0 on OCP 4.8
OCP 4.8.0-0.nightly-2021-03-26-054333

InstallPlan failed:

error validating existing CRs against new CRD's schema: checlusters.org.eclipse.che: error validating custom resource against new schema &apiextensions.CustomResourceValidation{OpenAPIV3Schema:(*apiextensions.JSONSchemaProps)(0xc001a85200)}: [].status.openShiftOAuthUserCredentialsSecret: Invalid value: "null": status.openShiftOAuthUserCredentialsSecret in body must be of type string: "null"

Che version

  • 7.28.0

Steps to reproduce

  1. Run ocp 4.8 cluster
  2. Run test script

Expected behavior

Runtime

  • Openshift (include output of oc version)

Screenshots

Environment

  • Cloud
@tolusha tolusha added kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Mar 29, 2021
@ibuziuk ibuziuk added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. and removed severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. labels Mar 29, 2021
@ibuziuk
Copy link
Member

ibuziuk commented Mar 29, 2021

@tolusha wanted to put the blocker, or at least P1 prio for this, not sure why it is a P2 ;-)

@mkuznyetsov
Copy link
Contributor

@ibuziuk it was discovered during Che operator release 7.28.0, which is not finished yet. My question is, if it is blocker, do I halt the release until it is resolved, or ignore it for now and complete 7.28.0 release (and consider it for bugfix release)?

@tolusha
Copy link
Contributor Author

tolusha commented Mar 29, 2021

@ibuziuk
The reason is the following:

  1. It is the first release when we run tests against ocp 4.8, so the bug probably existed before but we never noticed
  2. It is nightly OCP build (not a stable version)
  3. Tests passed on 4.6 and 4.7

@flacatus
Copy link
Contributor

flacatus commented Mar 29, 2021

I'm wondering if we should add here(https://github.com/eclipse-che/che-operator/blob/master/pkg/apis/org/v1/che_types.go#L568) to checluster api ``json:"openShiftOAuthUserCredentialsSecret, omitempty"`.

@ibuziuk
Copy link
Member

ibuziuk commented Mar 29, 2021

It is nightly OCP build (not a stable version)

@tolusha will let you decide what the priority is, but IMO it is a red sign that could become a potential blocker

@tolusha tolusha added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Mar 30, 2021
@tolusha tolusha added this to the 7.30 milestone Apr 12, 2021
@tolusha tolusha closed this as completed Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants