Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devfile registry: it is not clear in which order to execute commands in some devfiles #19458

Closed
1 of 23 tasks
sunix opened this issue Mar 30, 2021 · 7 comments
Closed
1 of 23 tasks

Devfile registry: it is not clear in which order to execute commands in some devfiles #19458

sunix opened this issue Mar 30, 2021 · 7 comments
Labels
area/devfile-registry good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@sunix
Copy link
Contributor

sunix commented Mar 30, 2021

Describe the bug

Some devfiles have several commands that need to be executed in a precise order to succeed.
Some are named with prefixed numbers that help the user, but some others are not.

For instance:

  • angular
  • python-django

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. start the Django Python devfile
  2. open my workspace view
  3. start the first command: install dependencies
  4. it fails sh: 1: .: Can't open /projects/.venv/bin/activate

Expected behavior

the commands should be prefixed with numbers that would tell which one to start. in this case, user should execute the command set up venv first, but it is listed in alphabetical order: at the end.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Selection_301

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • Dev Sandbox (workspaces.openshift.com)
  • other: please specify

Eclipse Che Logs

Additional context
@sunix sunix added the kind/bug Outline of a bug - must adhere to the bug report template. label Mar 30, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 30, 2021
@sunix sunix added the good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! label Mar 30, 2021
@mshaposhnik mshaposhnik added area/devfile-registry severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 30, 2021
@l0rd
Copy link
Contributor

l0rd commented Mar 31, 2021

The numbers are a workaround but the right solution is to run the prerequisite commands if they haven't been run before.

@l0rd
Copy link
Contributor

l0rd commented Mar 31, 2021

Also it would be nice to see the list of examples that have this problem in this issue. We could make it an epic. Adding n&n label anyway as that has a important impact on UX, especially for new users.

@l0rd l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Mar 31, 2021
@sunix
Copy link
Contributor Author

sunix commented Mar 31, 2021

The numbers are a workaround but the right solution is to run the prerequisite commands if they haven't been run before.

Could this be part of devfile v2?

@l0rd
Copy link
Contributor

l0rd commented Mar 31, 2021

Could this be part of devfile v2?

v2 has composite commands. I don't think it will solve the problem though.

@l0rd l0rd removed the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Sep 28, 2021
@che-bot
Copy link
Contributor

che-bot commented Mar 27, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 27, 2022
@svor
Copy link
Contributor

svor commented Mar 31, 2022

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 31, 2022
@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 27, 2022
@che-bot che-bot closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/devfile-registry good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@l0rd @sunix @svor @mshaposhnik @che-bot