Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Error during Che user deactivation when Keycloak cascade user removal is enabled #19473

Closed
ibuziuk opened this issue Mar 31, 2021 · 3 comments
Assignees
Labels
area/hosted-che kind/bug Outline of a bug - must adhere to the bug report template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current status/release-notes-review-done Issues that have been reviewed by the doc team for the Release Notes wording
Milestone

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Mar 31, 2021

Is your task related to a problem? Please describe

During the deactivation GDPR process, some accounts were in an inconsistent state - user existed in che db, but was removed on keylock / sso

Describe the solution you'd like

Need to figure how this situation could occur

Describe alternatives you've considered

When a user does not exist in keycloak, but exists in Che db - remove the user only on Che end, without failure:

java.io.IOException: Failed access: https://<domain> openshiftapps.com/auth/admin/realms/codeready/users/xxx, method: DELETE, response code: 404, message: {"error":"User not found"}

Release Notes Text

After the deactivation of inactive users, some accounts were in an inconsistent state: user existed in Che postgres database but was removed from Keycloak. That produced an error. This has been fixed now: when a user does not exist in Keycloak, but exists in Che postgres database - remove it without failure.

@ibuziuk ibuziuk added kind/task Internal things, technical debt, and to-do tasks to be performed. kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/hosted-che sprint/next and removed kind/task Internal things, technical debt, and to-do tasks to be performed. labels Mar 31, 2021
@ibuziuk ibuziuk added this to the 7.30 milestone Mar 31, 2021
@ibuziuk ibuziuk self-assigned this Apr 26, 2021
@ibuziuk ibuziuk modified the milestones: 7.30, 7.31 May 5, 2021
@ibuziuk ibuziuk removed this from the 7.31 milestone May 26, 2021
@ibuziuk ibuziuk added this to the 7.32 milestone May 26, 2021
@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 14, 2021

PR for fixup and refactoring - eclipse-che/che-server#26

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 15, 2021

merged. Closing
should be part of 7.32 & CRW 2.10

@ibuziuk ibuziuk closed this as completed Jun 15, 2021
@l0rd l0rd changed the title Error during user deactivation with the enabled CHE_KEYCLOAK_CASCADE__USER__REMOVAL__ENABLED property Error during Che user deactivation when Keycloak cascade user removal is enabled Jun 24, 2021
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Jun 24, 2021
@MichalMaler
Copy link
Contributor

@MichalMaler MichalMaler added status/release-notes-review-done Issues that have been reviewed by the doc team for the Release Notes wording and removed status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Jun 29, 2021
@MichalMaler MichalMaler changed the title Error during Che user deactivation when Keycloak cascade user removal is enabled Fix: Error during Che user deactivation when Keycloak cascade user removal is enabled Jun 29, 2021
@ibuziuk ibuziuk assigned ibuziuk and unassigned ibuziuk Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hosted-che kind/bug Outline of a bug - must adhere to the bug report template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current status/release-notes-review-done Issues that have been reviewed by the doc team for the Release Notes wording
Projects
None yet
Development

No branches or pull requests

3 participants