Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the multi-root mode for Go devfile #19476

Closed
RomanNikitenko opened this issue Apr 1, 2021 · 1 comment
Closed

Enable the multi-root mode for Go devfile #19476

RomanNikitenko opened this issue Apr 1, 2021 · 1 comment
Assignees
@sunix
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone
7.31

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Apr 1, 2021 •
edited

Is your task related to a problem? Please describe.

At the moment the multi-root mode is disabled for Go devfile
It was disabled because there is no code completion: #19375 (comment)

I quickly tested and looks like the code completion works with enabled multi-root mode and enabled GO111MODULE.

multi-root-on

Also I don't have errors in the Problems view when the multi-root mode is ON.
I have a lot of errors when the multi-root mode is OFF:

multi-root-off

For testing I did the following:

  • replacing the value for GO111MODULE by on here
  • give memoryLimit: 2Gi for Go component
  • wait for Loading packages process - you can see the corresponding loader in the status bar when you open a go file after starting a workspace

Describe the solution you'd like

My propose is:

  • test the base Go functionality with enabled GO111MODULE
  • if it doesn't help - investigate what should be done to get Go functionality working in the multi-root mode for Che.

Describe alternatives you've considered

Additional context
@RomanNikitenko RomanNikitenko added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Apr 1, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 1, 2021
@RomanNikitenko RomanNikitenko added area/plugins severity/P1 Has a major impact to usage or development of the system. labels Apr 1, 2021
@olexii4 olexii4 removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 2, 2021
@l0rd l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Apr 2, 2021
@ericwill ericwill mentioned this issue Apr 8, 2021
Closed
42 tasks
@ericwill ericwill added this to the 7.30 milestone Apr 14, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Apr 19, 2021
Closed
9 tasks
@ericwill ericwill modified the milestones: 7.30, 7.31 Apr 27, 2021
@ericwill ericwill mentioned this issue Apr 29, 2021
Closed
32 tasks
@sunix sunix mentioned this issue May 5, 2021
Merged
9 tasks
@ericwill
Copy link
Contributor

ericwill commented May 5, 2021

Fixed by eclipse-che/che-devfile-registry#387

@ericwill ericwill closed this as completed May 5, 2021
@l0rd l0rd removed the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunix sunix

Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Milestone
7.31
Development

No branches or pull requests
6 participants
@l0rd @sunix @RomanNikitenko @ericwill @olexii4 @che-bot