Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check if devworkspace engine is disabled before devfile 2.x schema validation #20273

Closed
Tracked by #20326
skabashnyuk opened this issue Aug 9, 2021 · 0 comments
Assignees
Labels
area/che-server area/factory/server Server side of factory implementation kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone

Comments

@skabashnyuk
Copy link
Contributor

Is your task related to a problem? Please describe

Users got an error if devwoorkspace engine is not enabled


Failed to create a workspace. Failed to create a new workspace from the devfile, reason: Devfile schema validation failed. Error: Exactly one of the following sets of problems must be resolved.: [(/components/1):The object must have a property whose name is "container".(/components/1):The object must have a property whose name is "kubernetes".(/components/1):The object must have a property whose name is "openshift".(/components/1):The object must have a property whose name is "volume".(/components/1):The object must have a property whose name is "plugin".]

Describe the solution you'd like

Before devfile 2.x schema validation throw an error (400 Badrequest) if devworkspace engine is disabled

Describe alternatives you've considered

No response

Additional context

https://issues.redhat.com/browse/CRW-2121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-server area/factory/server Server side of factory implementation kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

2 participants