Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard should report when there are errors in the product.json #20341

Closed
JPinkney opened this issue Aug 20, 2021 · 1 comment
Closed

Dashboard should report when there are errors in the product.json #20341

JPinkney opened this issue Aug 20, 2021 · 1 comment
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@JPinkney
Copy link
Contributor

Describe the bug

Right now if you create a malformed product.json in the dashboard the dashboard will attempt to load it, realize that the json is invalid, and then use the default product.json values embedded in the dashboard instead. We should have a notification that lets people know that the product.json isn't loading correctly because of it's malformed. This was originally reported in https://issues.redhat.com/browse/CRW-2176

Che version

7.34@latest

Steps to reproduce

  1. Create product.json in the dashboard and add an extra comma to make the json invalid
  2. Run the dashboard and observe that none of the values from the product.json you created are used, instead the default product.json values are used

Expected behavior

I would expect that the dashboard reports that the product.json is invalid so that admins know to fix it

Runtime

OpenShift

Screenshots

No response

Installation method

chectl/latest

Environment

Linux

Eclipse Che Logs

No response

Additional context

No response

@JPinkney JPinkney added kind/bug Outline of a bug - must adhere to the bug report template. area/dashboard severity/P2 Has a minor but important impact to the usage or development of the system. labels Aug 20, 2021
@sleshchenko sleshchenko added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Aug 26, 2021
@che-bot
Copy link
Contributor

che-bot commented Feb 22, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2022
@che-bot che-bot closed this as completed Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants