Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine-exec: expose exit code on failure #20343

Closed
benoitf opened this issue Aug 20, 2021 · 1 comment
Closed

machine-exec: expose exit code on failure #20343

benoitf opened this issue Aug 20, 2021 · 1 comment
Labels
area/machine-exec kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@benoitf
Copy link
Contributor

benoitf commented Aug 20, 2021

Is your enhancement related to a problem? Please describe

Now, on failure, we've a JSON-RPC method onExecError that is saying there was an error and we have a stack attribute containing the message like : 'this process has exited with error code 123`

export interface ExecErrorEvent {
    id: number;
    stack: string;
}

but we don't have the exitCode as a field

Describe the solution you'd like

Provides the exitCode as part of a new attribute so there is nothing to parse on client side to know the exit code.

Describe alternatives you've considered

N/A

Additional context

it seems exit code can be grabbed for kubectl tool:
https://github.com/kubernetes/kubernetes/pull/26541/files

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. area/machine-exec labels Aug 20, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 20, 2021
@tolusha tolusha added sprint/next team/deploy severity/P2 Has a minor but important impact to the usage or development of the system. labels Aug 20, 2021
@ericwill ericwill removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 23, 2021
@tolusha tolusha mentioned this issue Sep 3, 2021
29 tasks
@che-bot
Copy link
Contributor

che-bot commented Mar 7, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 7, 2022
@che-bot che-bot closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/machine-exec kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants