Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Whitelabel/branding] Support using alternate container for vsix-installer; use released versions #20368

Closed
nickboldt opened this issue Aug 26, 2021 · 2 comments
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@nickboldt
Copy link
Contributor

Describe the bug

As of 7.35, che-theia hardcodes the URL for the vsix-installer as quay.io/eclipse/che-theia-vsix-installer:next.

This is neither updated in the 7.35.x branch to point to a stable release like 7.35.0, nor is it exposed to the downstream productization process as a parameter that can easily be replaced by a different, more stable, product image.

Che version

next (development version)

Steps to reproduce

  1. Open this file https://github.com/eclipse-che/che-theia/blob/7.35.x/tools/devworkspace-handler/src/vsix-installer/vsix-installer-component-updater.ts#L33
  2. see line 33

Expected behavior

There should be a better way to change this value from a hardcoded :next build to a stable one

Che release process should replace :next with a real released version.

Downstream builds should have a way to whitelabel/rebrand/replace this image.

Runtime

Kubernetes (vanilla), OpenShift

Screenshots

No response

Installation method

other (please specify in additional context)

Environment

other (please specify in additional context)

Eclipse Che Logs

No response

Additional context

No response

@nickboldt nickboldt added kind/bug Outline of a bug - must adhere to the bug report template. area/ci CI build and releases, PR testing, & whitelabel/productization issues area/editor/theia Issues related to the che-theia IDE of Che labels Aug 26, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 26, 2021
@dmytro-ndp dmytro-ndp added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 26, 2021
@dmytro-ndp
Copy link
Contributor

It's needed for DevWorkspace support in CRW 2.11+

@azatsarynnyy
Copy link
Member

I'm closing it as we've got rid of vsix-installer separate image in eclipse-che/che-theia#1222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants