Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt devfile v2 happy-path tests to verify editors and extensions functionalities #20385

Closed
l0rd opened this issue Aug 31, 2021 · 7 comments
Closed
Assignees
Labels
area/devfile-spec Issues related to Devfile v2 area/qe kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current

Comments

@l0rd
Copy link
Contributor

l0rd commented Aug 31, 2021

Is your enhancement related to a problem? Please describe

This was initially part of this epic #18668

Now that the work to support theia running vs code extensions for workspaces started using devfile v2 has been completed, the happy path test should be updated if hasn't yet.

Describe the solution you'd like

The happy path test should use a factory link to a che-sample as https://github.com/che-samples/java-spring-petclinic/tree/devfilev2 (branch is devfilev2) ✔️
and verify that:

  • the workspace is started successfully
  • the Java LS works properly

Describe alternatives you've considered

No response

Additional context

No response

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Aug 31, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 31, 2021
@l0rd l0rd added area/qe severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 31, 2021
@benoitf
Copy link
Contributor

benoitf commented Sep 6, 2021

some notes:

step1: replace gist with che-samples repository ✔️
step2: Add tests on language server (like it's done on devfile v1)

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Sep 6, 2021

@sleshchenko
Copy link
Member

sleshchenko commented Sep 6, 2021

After discussion with QE team.
Statements:

  • We can't reuse devfile v1 happy path test scenario since it uses workspace created with chectl but not factory link;
  • We can't reuse pieces from devfile v1 happy path test since QE has conversion that test scenario must be in one file;

The plan we agreed on:

Later possible action item for QE:

  1. refactor tests to be able to use suites without copying-pasting;
  2. or fully align Devfile v1 and Devfile v2 happy path tests to make them live in a single file;

Personally, I prefer the first a bit more since I assume at some stage we can have different features needed to be verified.

@dmytro-ndp please verify and let me now if inaccuracies present;

P.S. Also we identified the following issue that should be handled separately Centralize DevWorkspace Happy Path test #20421

@dmytro-ndp
Copy link
Contributor

@sleshchenko: it looks accurate, thanks for summary!

@SkorikSergey SkorikSergey added the status/in-progress This issue has been taken by an engineer and is under active development. label Sep 7, 2021
@rhopp
Copy link
Contributor

rhopp commented Sep 7, 2021

refactor tests to be able to use suites without copying-pasting;

As for this point - we already have something like this. It's being adapted by Devfile tests, but HappyPath test (devfile.v1) is not using this.
We have generalized (and parameterized) test steps for common workspace verification in folder testsLibrary. You can see how it's used for example here: https://github.com/eclipse/che/blob/main/tests/e2e/tests/devfiles/JavaMaven.spec.ts#L50-L60

@musienko-maxim
Copy link
Contributor

The steps until Display source code changes in the running application and Validation of debug functionality were adapted. It was merged in PR: #20476
Currently we adpting: Display source code changes in the running application, Validation of debug functionality and

@sleshchenko
Copy link
Member

Validation of debug functionality can't be added due #20536

it will be added into happy path test along with Display source code changes in the running application in the scope of #20537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues related to Devfile v2 area/qe kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

8 participants