New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Language Server Protocol - part 2 #2109

Closed
gazarenkov opened this Issue Aug 12, 2016 · 1 comment

Comments

Projects
None yet
5 participants
@gazarenkov
Contributor

gazarenkov commented Aug 12, 2016

This is the second part of LS protocol implementation:

  • Language Server Protocol: ShowMessage Notification feature #1793
  • Language Server Protocol: ShowMessage Request feature #1794
  • Language Server Protocol: Telemetry Notification #1796
  • Language Server Protocol: DidChangeWatchedFiles Notification #1799
  • Language Server Protocol: Document Highlights #1802
  • Language Server Protocol: Push notification to client on new language server #1427
  • Language Server Protocol: Ensure order of Events #1426
  • Language Server Protocol: Rename feature #1806 (depends on #5955)
@TylerJewell

This comment has been minimized.

Show comment
Hide comment
@TylerJewell

TylerJewell Aug 20, 2016

Contributor

@gazarenkov - before we implement this second phase, we need to consider the following usability improvements:

  1. Softening some of the treatment of the phase 1 elements so that they have a more modern design to them vs. the heavy black lines.
  2. End user acceptance / rejection / installation / uninstallation of LS agents from within the IDE. LS will have licenses that require acceptance of the end user before they are installed into the ws. We should enable this capability in the UD & probably the IDE at the same time.
Contributor

TylerJewell commented Aug 20, 2016

@gazarenkov - before we implement this second phase, we need to consider the following usability improvements:

  1. Softening some of the treatment of the phase 1 elements so that they have a more modern design to them vs. the heavy black lines.
  2. End user acceptance / rejection / installation / uninstallation of LS agents from within the IDE. LS will have licenses that require acceptance of the end user before they are installed into the ws. We should enable this capability in the UD & probably the IDE at the same time.

xcoulon added a commit to xcoulon/che that referenced this issue Nov 18, 2016

Issue eclipse#2109 - DO NOT MERGE - Adding support for the 'test-lang…
…' protocol

Please do not merge this pull request. Its unique purpose is to add support
for a 'test-lang' server that can be used to test the upcoming pull requests
for the epic issue eclipse#2109.

To include the 'test-lang' server in the Che packaging:

```
git clone https://github.com/xcoulon/che-plugin-test-lang-server.git
cd che-plugin-test-lang-server
mvn clean install -Denforcer.skip=true -Dmdep.analyze.skip=true

git clone https://github.com/xcoulon/test-language-server.git
cd test-language-server
mvn clean install
```

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>

xcoulon added a commit to xcoulon/che that referenced this issue Nov 18, 2016

This pull request's unique purpose is to add support for a 'test-lang…
…' server that can be used to test the upcoming pull requests related to the epic issue eclipse#2109.

Issue eclipse#2109

To include the 'test-lang' server in the Che packaging:

```
git clone https://github.com/xcoulon/che-plugin-test-lang-server.git
cd che-plugin-test-lang-server
mvn clean install -Denforcer.skip=true -Dmdep.analyze.skip=true

git clone https://github.com/xcoulon/test-language-server.git
cd test-language-server
mvn clean install
```

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>

xcoulon added a commit to xcoulon/che that referenced this issue Dec 9, 2016

Issue 2109 - 'test-lang' server for: Support for Language Server Prot…
…ocol - part 2

This pull request's unique purpose is to add support for a 'test-lang' server that can be used to test the upcoming pull requests related to the epic issue eclipse#2109.

To include the 'test-lang' server in the Che packaging:

```
git clone https://github.com/xcoulon/che-plugin-test-lang-server.git
cd che-plugin-test-lang-server
mvn clean install -Denforcer.skip=true -Dmdep.analyze.skip=true

git clone https://github.com/xcoulon/test-language-server.git
cd test-language-server
mvn clean install
```

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>

@vparfonov vparfonov closed this Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment