Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust memory of plug-in registry container based on CheCluster settings #21620

Closed
Tracked by #20549 ...
benoitf opened this issue Aug 8, 2022 · 0 comments
Closed
Tracked by #20549 ...
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@benoitf
Copy link
Contributor

benoitf commented Aug 8, 2022

Is your enhancement related to a problem? Please describe

Today, OpenVSX could be run as part of the plug-in registry

But it consumes more memory than just the http service
So it would be nice if we want to use open-vsx.org and do not start OpenVSX in plug-in registry that we keep the low memoryLimit

Describe the solution you'd like

sets memory Request/Limit on plug-in registry based on the CheCluster openVSXURL flag

OpenVSXUrl:

  • user-defined value: low memory : 256Mi limit
  • empty : 2Gi and request to 500Mi

Discussion thread:
eclipse-che/che-plugin-registry#1324 (comment)

Based on that I would recommend a more robust memory setup done by che-operator:

if pluginRegistry.openVSXURL is NOT set we should set plugin registry memory:
limit to 2Gi
request to 500Mi
otherwise set the old (and less demanding) memory settings

Describe alternatives you've considered

Do not start plug-in registry at all (for example if editor is not CheTheia)

Additional context

No response

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Aug 8, 2022
@tolusha tolusha added this to the 7.53 milestone Aug 17, 2022
@tolusha tolusha closed this as completed Aug 17, 2022
@tolusha tolusha mentioned this issue Aug 17, 2022
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

2 participants