Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show the problem matcher prompt for Devfile commands in Che-Code #21651

Closed
Tracked by #21745
azatsarynnyy opened this issue Aug 23, 2022 · 2 comments
Closed
Tracked by #21745

Don't show the problem matcher prompt for Devfile commands in Che-Code #21651

azatsarynnyy opened this issue Aug 23, 2022 · 2 comments
Assignees
@RomanNikitenko
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P2 Has a minor but important impact to the usage or development of the system. sprint/current status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording
Milestone
7.56

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Aug 23, 2022 •
edited by l0rd

Is your enhancement related to a problem? Please describe

Every time the user runs a Devfile Command in Che-Code, they are asked for choosing a problem matcher for scanning an output.
image

That extra step is annoying and it is redundant in 99% of cases.

Describe the solution you'd like

When running a Devfile Command, Che-Code should use an empty problem matches list:
problemMatcher: []

So, the user won't be asked for choosing it manually.

Describe alternatives you've considered

It can be configured by the user. See the "task.problemMatchers.neverPrompt": true setting.

Release Notes Text

Every time a user runs a Devfile command in Che-Code they need to choose a problem matcher for scanning an output. This extra step is annoying and it is redundant in 99% of cases so it has been removed.
@azatsarynnyy azatsarynnyy added kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. team/editors area/editor/vscode Issues related to the Code OSS editor of Che labels Aug 23, 2022
@azatsarynnyy azatsarynnyy changed the title Don't ask for choosing a problem matcher when running a Devfile Command from Che-Code Don't ask for choosing a problem matcher when running a Devfile Command in Che-Code Aug 23, 2022
@azatsarynnyy azatsarynnyy mentioned this issue Oct 7, 2022
Closed
67 tasks
@azatsarynnyy azatsarynnyy added this to the 7.56 milestone Oct 12, 2022
@RomanNikitenko RomanNikitenko mentioned this issue Oct 12, 2022
Merged
@RomanNikitenko RomanNikitenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Oct 13, 2022
@l0rd l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Oct 13, 2022
@l0rd l0rd changed the title Don't ask for choosing a problem matcher when running a Devfile Command in Che-Code Don't show the problem matcher prompt for Devfile commands in Che-Code Oct 13, 2022
@l0rd l0rd added the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Oct 13, 2022
@azatsarynnyy
Copy link
Member Author

Now, VS Code won't ask the user to choose a problem matcher for parsing the output of the running Task if it represents a Devfile Command.
If one wants to specify a problem matcher for such a Task, it's still possible to customize the Task with the Configure Task feature.

@max-cx
Copy link

max-cx commented Dec 15, 2022

Sync'd with Red Hat JIRA https://issues.redhat.com/browse/CRW-3636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanNikitenko RomanNikitenko

Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P2 Has a minor but important impact to the usage or development of the system. sprint/current status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording
Projects
None yet
Milestone
7.56
Development

No branches or pull requests
4 participants
@l0rd @azatsarynnyy @RomanNikitenko @max-cx