Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpeted session expiration invalidation results in random logouts #21799

Closed
6 tasks done
ibuziuk opened this issue Nov 2, 2022 · 2 comments · Fixed by eclipse-che/che-dashboard#688
Closed
6 tasks done

Unexpeted session expiration invalidation results in random logouts #21799

ibuziuk opened this issue Nov 2, 2022 · 2 comments · Fixed by eclipse-che/che-dashboard#688
Assignees
@olexii4 @akurinnoy
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone
7.58

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Nov 2, 2022 •
edited by l0rd
Loading

Describe the bug

  1. suddenly developer gets logged out
  2. session expiration is not handled, developers are not informed and see a list of errors instead

Che version

7.55@latest

Steps to reproduce

  • Launch IDE with devfile URL
  • IDE launch as expected
  • Update .devfile.yaml in repo
  • Switch back to DevSpaces UI (to delete current space)
    See attached error
  • Must close the many errors, hit refresh, login, logout, login

image

Expected behavior

  • if k8s API is failing on che-dashboard backend we should try to retry a couple of times before failing @olexii4
  • re-try on che-dashboard-client side che-server API calls (namespace provisioning) @akurinnoy
  • add API sanity check with a single request to prevent showing multiple error messages @akurinnoy
  • if after all checks above and re-tries API is still failing we show a single error with the session expired message and redirect to the login page @akurinnoy

Runtime

OpenShift

Screenshots

No response

Installation method

OperatorHub

Environment

Amazon

Eclipse Che Logs

No response

Additional context

Related issues that should be addressed as part of this issue

Release Notes Text

Before this fix the developer could be logged out unexpectedly because the session expired for unknown reasons.
@ibuziuk ibuziuk added kind/bug Outline of a bug - must adhere to the bug report template. sprint/current severity/P1 Has a major impact to usage or development of the system. area/dashboard labels Nov 2, 2022
@ibuziuk ibuziuk mentioned this issue Nov 2, 2022
Closed
73 tasks
@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 3, 2022 •
edited
Loading

Related issues that should be addressed as part of this issue

@ibuziuk ibuziuk mentioned this issue Nov 22, 2022
Closed
68 tasks
@akurinnoy akurinnoy mentioned this issue Nov 25, 2022
Merged
@akurinnoy akurinnoy mentioned this issue Dec 12, 2022
Merged
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Dec 15, 2022
@max-cx max-cx removed the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Jan 12, 2023
@nickboldt nickboldt added this to the 7.58 milestone Jan 12, 2023
@devstudio-release
Copy link

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-3846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olexii4 olexii4

@akurinnoy akurinnoy

Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Milestone
7.58
Development

Successfully merging a pull request may close this issue.

Re-try namespace provisioning eclipse-che/che-dashboard
7 participants
@nickboldt @l0rd @ibuziuk @olexii4 @akurinnoy @devstudio-release @max-cx