Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent commands are not available in VS Code tasks #22373

Closed
l0rd opened this issue Jul 18, 2023 · 1 comment · Fixed by che-incubator/che-code#197
Closed

Parent commands are not available in VS Code tasks #22373

l0rd opened this issue Jul 18, 2023 · 1 comment · Fixed by che-incubator/che-code#197
Assignees
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Jul 18, 2023

Describe the bug

When a devfile uses a parent and the parent has some commands those are not visible as tasks in VS Code. This is probably due to the fact that the commands have the attribute controller.devfile.io/imported-by: parent in the flattened devfile:

- attributes:
    controller.devfile.io/imported-by: parent
  exec:
    commandLine: ./mvnw clean package -DskipTests=true
    component: tools
    group:
      isDefault: true
      kind: build
    label: 1. Package
  id: package

Che version

7.71@latest

Steps to reproduce

Start a workspace using the branch parent of this git repository: https://github.com/l0rd/inventory-quarkus/

Expected behavior

I would like to see the parents commands but I only see the ones coming from the devfile:

image
@l0rd l0rd added kind/bug Outline of a bug - must adhere to the bug report template. area/editor/vscode Issues related to the Code OSS editor of Che severity/P1 Has a major impact to usage or development of the system. labels Jul 18, 2023
@azatsarynnyy
Copy link
Member

azatsarynnyy commented Jul 19, 2023

@amisevsk noticed that problem a few months ago. I prepared a PR che-incubator/che-code#197 with a patch but then forgot about it 🤦‍♂️
Now, the PR is updated and ready for review.

In a patched Che-Code:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/vscode Issues related to the Code OSS editor of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants