Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The UD does not have a length limitation for auto-generated names #22758

Closed
olexii4 opened this issue Jan 10, 2024 · 5 comments · Fixed by eclipse-che/che-dashboard#1045 or eclipse-che/che-dashboard#1069
Assignees
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@olexii4
Copy link
Contributor

olexii4 commented Jan 10, 2024

Describe the bug

It is impossible to create a new workspace from a git repository URL when the repository doesn't have a Devfile and its path includes more than 63 characters.

Che version

7.79@latest

Steps to reproduce

  1. Open the Create Workspace page.
  2. Paste an unexisted URL https://github.com/olexii4/che-editor-theiahkhjkhkjhkjhjhghjhgfghfhgfhgjfghfghjfghjfhgfghfghjfhgfghfhgjfhgjfhg.
  3. Press 'Create & Open'.
  4. Continue with a default devfile.

Expected behavior

It should create a new workspace with a name shorter than 63 characters.

Runtime

OpenShift

Screenshots

Знімок екрана 2024-01-10 о 15 42 20

Installation method

chectl/latest, chectl/next

Environment

macOS

Eclipse Che Logs

No response

Additional context

No response

@olexii4 olexii4 added kind/bug Outline of a bug - must adhere to the bug report template. area/dashboard labels Jan 10, 2024
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 10, 2024
@olexii4 olexii4 changed the title The UD does not have a length limitation for auto-generated devworkspace names The UD does not have a length limitation for auto-generated names Jan 10, 2024
@olexii4 olexii4 added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 10, 2024
@olexii4 olexii4 self-assigned this Jan 17, 2024
@dmytro-ndp
Copy link
Contributor

@olexii4: hello,
I have reproduced the error on Che dogfooding instance (Eclipse Che Next) and DevSandbox Stage with Dev Spaces 3.12.0 (Eclipse Che 7.82.x):
Screenshot from 2024-03-11 19-07-17

Screenshot from 2024-03-11 19-07-52

Therefore, reopening the issue for further investigation.

@dmytro-ndp dmytro-ndp reopened this Mar 11, 2024
@olexii4
Copy link
Contributor Author

olexii4 commented Mar 12, 2024

@dmytro-ndp It is not about length limitation for auto-generated names. We have a different problem now: che-server generates an invalid devfile in the case with an unexisting repo.
Знімок екрана 2024-03-12 о 10 25 43

We should create a new issue for che-server and close this one.

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Mar 12, 2024

@olexii4 : thanks for the answer.
Actually, I tested issue resolution using unexisted repo, because it was in "Steps to reproduce" of description of the issue:
screenshot-github com-2024 03 12-12_59_33

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Mar 12, 2024

@olexii4 : The error has been reproduced on Dev Spaces 3.12.0 deployed to the DevSandbox Stage with an existing repository having a 70-character-long name: https://github.com/dmytro-ndp/70_symbols_long_repo_name_kkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkk
Screenshot from 2024-03-12 14-12-03

Note: click on "Continue with default devfile" button at the error page is leading to the same error page.

@olexii4
Copy link
Contributor Author

olexii4 commented Mar 12, 2024

@dmytro-ndp I investigated the problem. It happened because of the changes in che-server behavior.

We can test these changes with a custom repository instead of github.com.

Steps to reproduce:

  1. Open the Create Workspace page.
  2. Paste an unexisted URL https://custom.repo/olexii4/che-editor-theiahkhjkhkjhkjhjhghjhgfghfhgfhgjfghfghjfghjfhgfghfghjfhgfghfhgjfhgjfhg.
  3. Press 'Create & Open'.
  4. Continue with a default devfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
3 participants