Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revoke git service action is available after apply #22790

Closed
vinokurig opened this issue Jan 25, 2024 · 0 comments · Fixed by eclipse-che/che-dashboard#1065
Closed

Revoke git service action is available after apply #22790

vinokurig opened this issue Jan 25, 2024 · 0 comments · Fixed by eclipse-che/che-dashboard#1065
Assignees
@akurinnoy
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che

Comments

@vinokurig
Copy link
Contributor

vinokurig commented Jan 25, 2024 •
edited by dmytro-ndp
Loading

Describe the bug

It is possible to execute the revoke git service action after its actual execution.

Che version

7.80@latest

Steps to reproduce

  1. Setup GitHub oauth: https://eclipse.dev/che/docs/stable/administration-guide/configuring-oauth-2-for-github
  2. Start a workspace from a GitHub repository, accept the GitHub token agreement.
  3. Go to the dashboard Git Services tab and revoke the GitHub authorization.
  4. Quickly go to the Personal Access Tokens tab and then quickly switch back to the Git Services tab.
  5. See: the GitHub still has an authorized state as the provision request was ignored and the related oauth token was not deleted.
  6. Revoke the GitHub authorization.
  7. See: a notification about successful revoke appears and the authorization status is changed to unauthorized.

Expected behavior

The git service must be in the unauthorized state and the revoke action must be always inactive after revoking.

Runtime

OpenShift

Screenshots

No response

Installation method

chectl/latest

Environment

macOS

Eclipse Che Logs

No response

Additional context

The same issue has been reproduced with GitLab git provider:
screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.03.16-02_09_36.webm
@vinokurig vinokurig added the kind/bug Outline of a bug - must adhere to the bug report template. label Jan 25, 2024
@vinokurig vinokurig changed the title Revoke git service action is available after apply. Revoke git service action is available after apply Jan 25, 2024
@vinokurig vinokurig added area/dashboard team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che labels Jan 25, 2024
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 25, 2024
@AObuchow AObuchow removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 30, 2024
@akurinnoy akurinnoy self-assigned this Mar 8, 2024
@akurinnoy akurinnoy mentioned this issue Mar 8, 2024
Merged
This was referenced Mar 13, 2024
Closed
Merged
@dmytro-ndp dmytro-ndp added the severity/P2 Has a minor but important impact to the usage or development of the system. label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akurinnoy akurinnoy

Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix revoking of Git service tokens eclipse-che/che-dashboard
5 participants
@dmytro-ndp @vinokurig @AObuchow @akurinnoy @che-bot