Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When user click exit button terminal process will not be killed if terminal has child processes. #3216

Closed
AndrienkoAleksandr opened this issue Nov 30, 2016 · 0 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Milestone

Comments

@AndrienkoAleksandr
Copy link
Contributor

Reproduction Steps:

  1. Create new terminal.
  2. Open Midnight Commander (mc) in the teminal.
  3. Click close button.
    Expected behavior:
    Terminal process and child processes should be killed.

Observed behavior:
Terminal process is still alive, but mc process was killed.

PS: When we click close button our UI send exit command. Exit command can kill terminal if terminal hasn't child process. If terminal has child processes then exit command can be redirected to the child process, for example mc, and terminal is alive. I think we should implement special command to kill terminal and child processes of the terminal.

Che version: 5.0.0-M8-SNAPSHOT

Additional information:

  • Problem started happening recently, didn't happen in an older version of Che: [No]
  • Problem can be reliably reproduced, doesn't happen randomly: [Yes]
@AndrienkoAleksandr AndrienkoAleksandr added the kind/bug Outline of a bug - must adhere to the bug report template. label Nov 30, 2016
@AndrienkoAleksandr AndrienkoAleksandr changed the title When user click exit button terminal process will not be killed if it has child processes. When user click exit button terminal process will not be killed if terminal has child processes. Nov 30, 2016
@vkuznyetsov vkuznyetsov added sprint/next status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Dec 1, 2016
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Dec 8, 2016
@AndrienkoAleksandr AndrienkoAleksandr added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Dec 8, 2016
@AndrienkoAleksandr AndrienkoAleksandr added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Dec 14, 2016
@AndrienkoAleksandr AndrienkoAleksandr added this to the 5.1.0 milestone Jan 11, 2017
@AndrienkoAleksandr AndrienkoAleksandr removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

No branches or pull requests

2 participants