Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change signature of the org.eclipse.che.ide.api.resources.Resource#getParent #3242

Closed
vzhukovs opened this issue Dec 1, 2016 · 0 comments
Closed

Change signature of the org.eclipse.che.ide.api.resources.Resource#getParent #3242

vzhukovs opened this issue Dec 1, 2016 · 0 comments
Assignees
@vzhukovs
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone
5.1.0

Comments

@vzhukovs
Copy link
Contributor

vzhukovs commented Dec 1, 2016

There is no need to return parent as optional. So method signature can be renamed to return actual instance of org.eclipse.che.ide.api.resources.Container instead of com.google.common.base.Optional. Name of the method won't be changed.
@vzhukovs vzhukovs added kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. team/plugin labels Dec 1, 2016
@vzhukovs vzhukovs self-assigned this Dec 1, 2016
@vzhukovs vzhukovs mentioned this issue Dec 1, 2016
Closed
5 tasks
@vzhukovs vzhukovs mentioned this issue Jan 11, 2017
Merged
@vzhukovs vzhukovs added this to the 5.1.0 milestone Jan 12, 2017
@vzhukovs vzhukovs removed the status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. label Jan 13, 2017
@JamesDrummond JamesDrummond mentioned this issue Jan 31, 2017
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vzhukovs vzhukovs

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
1 participant
@vzhukovs