Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected grouping of create new project menu items #3759

Closed
aleksei-burlakov opened this issue Jan 17, 2017 · 11 comments
Closed

unexpected grouping of create new project menu items #3759

aleksei-burlakov opened this issue Jan 17, 2017 · 11 comments
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.

Comments

@aleksei-burlakov
Copy link

I have added a new item in che/instance/data/templates/samples.json Its name is Clustering and its category is Blank. It is expected to see the Clustering project in the same Blank group, but it is put in another Blank group.

capture

The question is if it is expected behaviour? If so, is there a way to put both blank groups together?

OS and version:

Che version: 5.0.0
OS and version: Ubuntu 16.04
Docker version: 1.12.5

@ghost ghost added the kind/question Questions that haven't been identified as being feature requests or bugs. label Jan 17, 2017
@ghost
Copy link

ghost commented Jan 17, 2017

@aleksei-burakov it is expected behavior at the moment. If you want your sample to get into the sample list in the IDE, you need to choose Samples category otherwise Che will create a new one.

@aleksei-burlakov
Copy link
Author

I have created Marmolata category (as on the picture) and I want it to consist of both of plugins registered by newSetBinder(...).addBinding().to(MyPlugin.class) and samples cofigured in che/instance/data/templates/samples.json . Che separates them. It's a matter of choise of course, but imho its expected to have them together. Anyway it would be good to have an option to put them together.

@ghost
Copy link

ghost commented Jan 17, 2017

Che separates sample projects and project templates. Have you registered a custom project type and you want your plugin to provide samples?

@aleksei-burlakov
Copy link
Author

Yes. I have implemented a ProjectWizardRegistrar class , ie a new plugin. It has created the Marmolata group. I would also like to put some samples from samples.json in that group.

@aleksei-burlakov
Copy link
Author

The problem is not to implement a plugin, but to rearrange plugins and samples on the list in new project dialog. As you see on the picture below there are two Marmolata groups. It is desired to have only one with the four elements.

capture

@ghost
Copy link

ghost commented Jan 17, 2017

You may add clustering to the list of templates that your plugin provides. So, ignore samples.json at all at this point.

@aleksei-burlakov
Copy link
Author

If I add it as a plugin I will have to hardcode it. When it is configured in stacks.json, it gets cloned from a git repository.

@aleksei-burlakov
Copy link
Author

This is an essential difference.

@ghost
Copy link

ghost commented Jan 17, 2017

@aleksei-burakov so is current behavior. Creating a project from scratch (this is where your 3 other samples are) implies creating a file with little or no cotent at all. Some plugins use generators (like php composer or maven archetype).

@vparfonov may help you customize this behavior.

@aleksei-burlakov
Copy link
Author

aleksei-burlakov commented Jan 17, 2017

Thank you, I think I will live it as is by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.
Projects
None yet
Development

No branches or pull requests

1 participant