Adapt the CSharpFileEditingTest after latest changes in Csharp language server #10166
Conversation
benoitf
added
the
status/code-review
musienko-maxim
changed the title
| @@ -10,14 +10,16 @@ | |||
| */ | |||
| package org.eclipse.che.selenium.languageserver; | |||
|
|
|||
| import static org.eclipse.che.selenium.core.constant.TestTimeoutsConstants.MINIMUM_SEC; | |||
| import static org.eclipse.che.selenium.pageobject.CodenvyEditor.MarkerLocator.*; | |||
There was a problem hiding this comment.
Grouping of imports is not good practice.
| } | ||
|
|
||
| private void reInitLanguageServer() { | ||
| private void restoreLanguageServer() { |
There was a problem hiding this comment.
We are not restoring language server directly here, aren't we?
We are doing something which lead to restoring language server. It's kind of magic which have to be commented clearly, and method name should reflect the magic explicitely.
| editor.waitMarkerInPosition(INFO, 2); | ||
| } catch (TimeoutException ex) { | ||
| // remove try-catch block after issue has been resolved | ||
| fail("https://github.com/eclipse/che/issues/10151"); |
There was a problem hiding this comment.
Error message is unclear.
benoitf
added
the
kind/task
|
|
||
| @AfterMethod | ||
| public void restartWorkspace() throws Exception { | ||
| if (testWorkspaceServiceClient.getStatus(workspace.getId()).equals(WorkspaceStatus.RUNNING)) { |
There was a problem hiding this comment.
What if workspace is not running at the moment? It doesn't mean that workspace is restarting at the moment, or language server will be restarted as well, do it?
|
ci-build |
|
Build # 4558 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4558/ to view the results. |
|
ci-build |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4560/ |
benoitf
removed
the
status/code-review
…ge server (eclipse-che#10166) * Adapt the test after latest changes for C sharp language server
What does this PR do?
What issues does this PR fix or reference?
#9925
@dmytro-ndp @SkorikSergey @Ohrimenko1988