Add Bearer token prefix for project service requests #10477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
added
kind/bug
sleshchenko
reviewed
Jul 19, 2018
| @@ -38,6 +38,8 @@ | |||
| */ | |||
| @Singleton | |||
| public class TestProjectServiceClient { | |||
|
|
|||
| private final String BEARER_TOKEN_PREFIX = "Bearer "; | |||
There was a problem hiding this comment.
Should not be constant marked with static?
|
Looks great, but what about change target branch from "master" to "exclusions". Because as I understood this PR fixes the problem which appears in the "exclusions" branch. And it will be nice to merge this branch to "exclusions" branch and rerun tests. |
|
I'll merge that into my feature branch, and then will request QE review on it. |
benoitf
added
target/branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds "Bearer" token identifier for the all project service related requests, since it is required by jwtproxy.
That can greatly reduce number of failing tests on jwtproxy auth.
What issues does this PR fix or reference?
Release Notes
N/A
Docs PR
N/A