Rework GitStatusProvider to use cached status storage #10690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinokurig
added
kind/bug
vinokurig
changed the title
vinokurig
requested review from
dmytro-ndp,
musienko-maxim and
Ohrimenko1988
as code owners
vinokurig
changed the title
vinokurig
added
status/code-review
vparfonov
reviewed
Aug 22, 2018
| @@ -1,119 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
Don't remove this class for now, just mark as Deprecated
vparfonov
reviewed
Aug 22, 2018
| collectProjectFiles(rootDirPathProvider.get()); | ||
| } | ||
|
|
||
| private void collectProjectFiles(String root) { |
There was a problem hiding this comment.
I propose add @PostConstruct and remove call this method from constructor
vparfonov
approved these changes
Aug 27, 2018
|
ci-test |
|
ci-test build report: |
musienko-maxim
approved these changes
Aug 28, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
JGit status command on big projects (Eclipse Che) uses a lot of RAM.
When deep expand to some folder is performed, Git status is called on each folder expand:
This causes a huge leap of RAM and finally OOM appears:
In this PR
GitStatusProvideris reworked to call Git status only if it is really needed e.g. file was modified. The provider is based on a cached Git Status Map that is updated from Git Events.What issues does this PR fix or reference?
#10696
Release Notes
Fix
java.lang.OutOfMemoryErroron large projects.Docs PR
N/A