CHE-946: [dashboard] improve workspace details page with error status #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -227,26 +240,26 @@ class IdeSvc { | |||
| return startWorkspacePromise; | |||
| } | |||
|
|
|||
| connectToExtensionServer(websocketURL, workspaceId) { | |||
| connectToExtensionServer(workspaceId, websocketURL) { | |||
There was a problem hiding this comment.
maybe we shouldn't change the order of params to avoid potential failures
There was a problem hiding this comment.
you're right, I'll revert it
akurinnoy
force-pushed
the
CHE-946
branch
2 times, most recently
from
b723709
to
e729fed
Compare
|
+1 |
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_1 Upvote_ - improve workspace details page with error status
Signed-off-by: Oleksii Kurinnyi okurinnyi@codenvy.com